LayoutTests/fast/dom/DOMException/stack-trace.html - Issue 16818023: DOMException toString is not correct

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/DOMException/stack-trace.html

Issue 16818023: DOMException toString is not correct (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/DOMException/resources/dispatch-event-exception.js ('k') | LayoutTests/fast/dom/DOMException/stack-trace-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../js/resources/js-test-pre.js"></script>	2 <script src="../../js/resources/js-test-pre.js"></script>

3 <script>	3 <script>

4	4

5 if (typeof testRunner !== 'undefined')	5 if (typeof testRunner !== 'undefined')

6 testRunner.dumpAsText();	6 testRunner.dumpAsText();

7	7

8 // ES6 polyfill	8 // ES6 polyfill

9 if (!String.prototype.contains) {	9 if (!String.prototype.contains) {

10 String.prototype.contains = function(substring) {	10 String.prototype.contains = function(substring) {

(...skipping 17 matching lines...) Expand all Loading...
28 } catch (ex) {	28 } catch (ex) {

29 e = ex;	29 e = ex;

30 }	30 }

31	31

32 shouldBeTrue('"stack" in e');	32 shouldBeTrue('"stack" in e');

33 shouldBeEqualToString('typeof e.stack', 'string');	33 shouldBeEqualToString('typeof e.stack', 'string');

34 shouldBeTrue('e.stack.contains("innerFunction")');	34 shouldBeTrue('e.stack.contains("innerFunction")');

35 shouldBeTrue('e.stack.contains("outerFunction")');	35 shouldBeTrue('e.stack.contains("outerFunction")');

36	36

37 shouldBeEqualToString('Object.prototype.toString.call(e)', '[object DOMException ]');	37 shouldBeEqualToString('Object.prototype.toString.call(e)', '[object DOMException ]');

	38 shouldBeEqualToString('e.toString()', 'HierarchyRequestError: A Node was inserte d somewhere it doesn\'t belong.');

38 shouldBeEqualToString('e.name', 'HierarchyRequestError');	39 shouldBeEqualToString('e.name', 'HierarchyRequestError');

39 shouldBeEqualToString('e.message', 'HierarchyRequestError: DOM Exception 3');	40 shouldBeEqualToString('e.message', 'A Node was inserted somewhere it doesn\'t be long.');

40 shouldBe('e.code', '3');	41 shouldBe('e.code', '3');

41	42

42 e.stack = 42;	43 e.stack = 42;

43 // Don't use shouldBe because the FAIL case still happens on JSC and we don't wa nt the output	44 // Don't use shouldBe because the FAIL case still happens on JSC and we don't wa nt the output

44 // to depend on the path.	45 // to depend on the path.

45 shouldBeTrue('e.stack === 42');	46 shouldBeTrue('e.stack === 42');

46	47

47 </script>	48 </script>

48 <script src="../../js/resources/js-test-post.js"></script>	49 <script src="../../js/resources/js-test-post.js"></script>

OLD	NEW