Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 168173003: Add temporary define to make some Skia constructors public. (Closed)

Created:
6 years, 10 months ago by Dominik Grewe
Modified:
6 years, 10 months ago
Reviewers:
reed1
CC:
chromium-reviews
Visibility:
Public.

Description

Add temporary define to make some Skia constructors public. We're currently in the process of enforcing that SkPaint effects can only be allocated on the heap. That involves making constructors non-public and providing factory methods instead. Until all the changes on the Skia side have been rolled into Chrome and the callsites have been changed, we use a define to guard the visibility of the constructors. BUG=skia:2187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M skia/skia_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dominik Grewe
PTAL
6 years, 10 months ago (2014-02-18 16:58:31 UTC) #1
reed1
lgtm
6 years, 10 months ago (2014-02-18 16:59:42 UTC) #2
Dominik Grewe
The CQ bit was checked by dominikg@chromium.org
6 years, 10 months ago (2014-02-18 17:05:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/168173003/1
6 years, 10 months ago (2014-02-18 17:05:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/168173003/1
6 years, 10 months ago (2014-02-18 18:21:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/168173003/1
6 years, 10 months ago (2014-02-18 18:29:52 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 20:50:43 UTC) #7
Message was sent while issue was closed.
Change committed as 251831

Powered by Google App Engine
This is Rietveld 408576698