Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
7 years, 6 months ago by tbarzic Modified:
7 years, 6 months ago Reviewers:
Greg Spencer (Chromium), oshima, asargent_no_longer_on_chrome CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sadrul, extensions-reviews_chromium.org, sail+watch_chromium.org, ben+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd ability to change display settings to chrome.systemInfo.display
TEST=manual on daisy, added unittests and extension api tests
BUG=237314
(on top of https://codereview.chromium.org/16687002/)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206576
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #
Total comments: 14
Patch Set 4 : . #Patch Set 5 : increased max bounds origin #
Total comments: 18
Patch Set 6 : . #Patch Set 7 : disallow_c&a #
Total comments: 8
Patch Set 8 : . #
Total comments: 4
Patch Set 9 : n #Patch Set 10 : . #
Total comments: 4
Patch Set 11 : . #Patch Set 12 : rebase #Patch Set 13 : win compile #
Created: 7 years, 6 months ago
Messages
Total messages: 22 (0 generated)
Greg, can you check that I'm not missing something raised at the api review :)
https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:31: const int kMaxBoundsOrigin = 0x3fff; Why in hex? Isn't this in "pixels"? https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:338: // whether the display was successfully updates. On failure, no display updates->updated https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:5: #include "chrome/browser/extensions/api/system_info_display/display_info_provider.h" Sorry, this is longer than 80 characters. You'll just have to move it to another directory. :-) (just kidding!) https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:123: #if defined(OS_CHROMEOS) Couldn't you just do #else here? https://codereview.chromium.org/16817006/diff/6001/chrome/common/extensions/a... File chrome/common/extensions/api/system_info_display.idl (right): https://codereview.chromium.org/16817006/diff/6001/chrome/common/extensions/a... chrome/common/extensions/api/system_info_display.idl:108: // is set. Note that, when updating the display origin, some constraints will >80 chars.
https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:31: const int kMaxBoundsOrigin = 0x3fff; On 2013/06/12 23:14:15, Greg Spencer (Chromium) wrote: > Why in hex? Isn't this in "pixels"? oh, I forgot to post a comment here: What would be the best value here (right now, I've set it so its square fits in 4 bytes; somewhat arbitrary :) ) https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:338: // whether the display was successfully updates. On failure, no display On 2013/06/12 23:14:15, Greg Spencer (Chromium) wrote: > updates->updated Done. https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:5: #include "chrome/browser/extensions/api/system_info_display/display_info_provider.h" On 2013/06/12 23:14:15, Greg Spencer (Chromium) wrote: > Sorry, this is longer than 80 characters. You'll just have to move it to > another directory. :-) (just kidding!) hehe, but it would be fun if we actually had to; new improved name for the file displ_inf_prov.h :) https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:123: #if defined(OS_CHROMEOS) On 2013/06/12 23:14:15, Greg Spencer (Chromium) wrote: > Couldn't you just do #else here? I don't know, I find this a bit easier to read.. I have nothing against changing it, thopugh https://codereview.chromium.org/16817006/diff/6001/chrome/common/extensions/a... File chrome/common/extensions/api/system_info_display.idl (right): https://codereview.chromium.org/16817006/diff/6001/chrome/common/extensions/a... chrome/common/extensions/api/system_info_display.idl:108: // is set. Note that, when updating the display origin, some constraints will On 2013/06/12 23:14:15, Greg Spencer (Chromium) wrote: > >80 chars. Done.
https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:31: const int kMaxBoundsOrigin = 0x3fff; On 2013/06/12 23:40:41, tbarzic wrote: > On 2013/06/12 23:14:15, Greg Spencer (Chromium) wrote: > > Why in hex? Isn't this in "pixels"? > > oh, I forgot to post a comment here: > What would be the best value here (right now, I've set it so its square fits in > 4 bytes; somewhat arbitrary :) ) I think the point was to limit the amount of overscan that you could specify so that it wouldn't be able to shrink the visible area to nothing. The docs says "Values that are less than 50% of the visible area of the display will be ignored." and I think what we meant by that was that if you took the ratio of the area of the visible area and the area of the overall display, it wouldn't be less than 1:2.
https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:31: const int kMaxBoundsOrigin = 0x3fff; On 2013/06/13 00:11:47, Greg Spencer (Chromium) wrote: > On 2013/06/12 23:40:41, tbarzic wrote: > > On 2013/06/12 23:14:15, Greg Spencer (Chromium) wrote: > > > Why in hex? Isn't this in "pixels"? > > > > oh, I forgot to post a comment here: > > What would be the best value here (right now, I've set it so its square fits > in > > 4 bytes; somewhat arbitrary :) ) > > I think the point was to limit the amount of overscan that you could specify so > that it wouldn't be able to shrink the visible area to nothing. The docs says > "Values that are less than 50% of the visible area of the display will be > ignored." and I think what we meant by that was that if you took the ratio of > the area of the visible area and the area of the overall display, it wouldn't be > less than 1:2. yeah, we have that check for insets.. this is used for setting the bounds origin withing logical display's system (the origin will ultimatively set by the display management so the displays share some part of their edge, but different value may be passed here)
https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:31: const int kMaxBoundsOrigin = 0x3fff; On 2013/06/13 00:18:25, tbarzic wrote: > yeah, we have that check for insets.. Oh, duh. Sorry, I thought it was being used for that check. > this is used for setting the bounds origin within logical display's system (the > origin will ultimately set by the display management so the displays share > some part of their edge, but different value may be passed here) Right, so we can pass a large value, but it'll be snapped back so that it's not disconnected from the other display. 16383 seems kind of small, especially if you consider 4K monitors (you could have four across someday). I'd say something 10x larger than that (~150K-200K) seems more future-proof, but still not insanely large. Is there a down side I'm not seeing? Could someone position a monitor so far out that it's no longer visible in the UI? But in that case, I think the display management would snap it back.
https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/6001/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:31: const int kMaxBoundsOrigin = 0x3fff; On 2013/06/13 00:57:04, Greg Spencer (Chromium) wrote: > On 2013/06/13 00:18:25, tbarzic wrote: > > yeah, we have that check for insets.. > > Oh, duh. Sorry, I thought it was being used for that check. > > > this is used for setting the bounds origin within logical display's system > (the > > origin will ultimately set by the display management so the displays share > > some part of their edge, but different value may be passed here) > > Right, so we can pass a large value, but it'll be snapped back so that it's not > disconnected from the other display. > 16383 seems kind of small, especially if you consider 4K monitors (you could > have four across someday). I'd say something 10x larger than that (~150K-200K) > seems more future-proof, but still not insanely large. Is there a down side I'm > not seeing? Could someone position a monitor so far out that it's no longer > visible in the UI? But in that case, I think the display management would snap > it back. set to 200 000
https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:256: *error = "Not allowed to mirror self."; i18n? shouldn't these error messages be in grd file? https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:299: if (info.rotation && !display_manager->IsDisplayRotationEnabled()) { IsDisplayRotatinoEnabled will be gone soon, so it's ok to remove this. https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:342: return manager->GetDisplayForId(gfx::Display::kInvalidDisplayID); just use return by value and return gfx::Display() https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:374: ExpectRectEquals(gfx::Rect(-520, 50, 520, 400), secondary->bounds()); Just FYI: following pattern makes it easy to read failure log (ash/aura uses this pattern a lot) EXPECT_EQ("-520,50 520x400", secondary->bounds().ToString()) https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:69: std::string GetSetInfoDisplayId() { const https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:77: std::string set_info_display_id_; DISALLOW_COPY_AND_ASSIGN https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:99: scoped_refptr<MockDisplayInfoProvider> provider_; DISALLOW_COPY_AND_ASSIGN
https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:256: *error = "Not allowed to mirror self."; On 2013/06/13 19:12:40, oshima wrote: > i18n? shouldn't these error messages be in grd file we don't do i18n for extension function error messages https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:299: if (info.rotation && !display_manager->IsDisplayRotationEnabled()) { On 2013/06/13 19:12:40, oshima wrote: > IsDisplayRotatinoEnabled will be gone soon, so it's ok to remove > this. Done. https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:342: return manager->GetDisplayForId(gfx::Display::kInvalidDisplayID); On 2013/06/13 19:12:40, oshima wrote: > just use return by value and return gfx::Display() Done. https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:374: ExpectRectEquals(gfx::Rect(-520, 50, 520, 400), secondary->bounds()); On 2013/06/13 19:12:40, oshima wrote: > Just FYI: following pattern makes it easy to read failure log (ash/aura uses > this pattern a lot) > > EXPECT_EQ("-520,50 520x400", secondary->bounds().ToString()) ok, changing to this pattern.. https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:69: std::string GetSetInfoDisplayId() { On 2013/06/13 19:12:40, oshima wrote: > const Done. https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:77: std::string set_info_display_id_; On 2013/06/13 19:12:40, oshima wrote: > DISALLOW_COPY_AND_ASSIGN there is an assign in SetupOnMainThread https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:99: scoped_refptr<MockDisplayInfoProvider> provider_; On 2013/06/13 19:12:40, oshima wrote: > DISALLOW_COPY_AND_ASSIGN Done.
https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:256: *error = "Not allowed to mirror self."; On 2013/06/13 20:58:15, tbarzic wrote: > On 2013/06/13 19:12:40, oshima wrote: > > i18n? shouldn't these error messages be in grd file > > we don't do i18n for extension function error messages Ah, this is for console? https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:77: std::string set_info_display_id_; On 2013/06/13 20:58:15, tbarzic wrote: > On 2013/06/13 19:12:40, oshima wrote: > > DISALLOW_COPY_AND_ASSIGN > > there is an assign in SetupOnMainThread Sorry if I misunderstand something, but looks like it's scoped_refptr. Super class doesn't allow copy semantics, so copy actually won't work, although you still should do this here.
https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:256: *error = "Not allowed to mirror self."; On 2013/06/13 21:17:34, oshima wrote: > On 2013/06/13 20:58:15, tbarzic wrote: > > On 2013/06/13 19:12:40, oshima wrote: > > > i18n? shouldn't these error messages be in grd file > > > > we don't do i18n for extension function error messages > > Ah, this is for console? yep https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc (right): https://codereview.chromium.org/16817006/diff/2003/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc:77: std::string set_info_display_id_; On 2013/06/13 21:17:34, oshima wrote: > On 2013/06/13 20:58:15, tbarzic wrote: > > On 2013/06/13 19:12:40, oshima wrote: > > > DISALLOW_COPY_AND_ASSIGN > > > > there is an assign in SetupOnMainThread > > Sorry if I misunderstand something, but looks like it's scoped_refptr. > Super class doesn't allow copy semantics, so copy actually won't work, > although you still should do this here. ah, sorry, my bad, it was failing to compile, but for another reason (added empty ctor and it works fine now)
lgtm my bits with nits https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc (right): https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:62: } const https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:77: } const https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:84: } const https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:85: }; DISALLOW_COPY_AND_ASSIGN
https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc (right): https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:62: } On 2013/06/13 21:51:17, oshima wrote: > const Done. https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:77: } On 2013/06/13 21:51:17, oshima wrote: > const Done. https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:84: } On 2013/06/13 21:51:17, oshima wrote: > const Done. https://codereview.chromium.org/16817006/diff/5018/chrome/browser/extensions/... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos_unittest.cc:85: }; On 2013/06/13 21:51:17, oshima wrote: > DISALLOW_COPY_AND_ASSIGN jeez, I keep forgetting these :(
https://codereview.chromium.org/16817006/diff/35001/chrome/common/extensions/... File chrome/common/extensions/api/system_info_display.idl (right): https://codereview.chromium.org/16817006/diff/35001/chrome/common/extensions/... chrome/common/extensions/api/system_info_display.idl:129: // Updates the properties for the monitor specified by provided identifier, optional suggestion: s/"specified by provided identifier"/"specified by |id|"/ https://codereview.chromium.org/16817006/diff/35001/chrome/common/extensions/... chrome/common/extensions/api/system_info_display.idl:138: static void setDisplayUnitInfo( Would it be better to name this "setDisplayProperties" or "updateMonitor" or something? The term "unit" seems sort of weird here (I know you use it to connote a single display in the results you get back from getDisplayInfo, but developers don't actually need to see it there).
https://codereview.chromium.org/16817006/diff/35001/chrome/common/extensions/... File chrome/common/extensions/api/system_info_display.idl (right): https://codereview.chromium.org/16817006/diff/35001/chrome/common/extensions/... chrome/common/extensions/api/system_info_display.idl:129: // Updates the properties for the monitor specified by provided identifier, On 2013/06/14 00:18:59, Antony Sargent wrote: > optional suggestion: s/"specified by provided identifier"/"specified by |id|"/ Done. https://codereview.chromium.org/16817006/diff/35001/chrome/common/extensions/... chrome/common/extensions/api/system_info_display.idl:138: static void setDisplayUnitInfo( On 2013/06/14 00:18:59, Antony Sargent wrote: > Would it be better to name this "setDisplayProperties" or "updateMonitor" or > something? The term "unit" seems sort of weird here (I know you use it to > connote a single display in the results you get back from getDisplayInfo, but > developers don't actually need to see it there). > > changed to setDisplayProperties
LGTM https://codereview.chromium.org/16817006/diff/39001/chrome/browser/extensions... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/39001/chrome/browser/extensions... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:332: DisplayManager* manager) { indent
lgtm https://codereview.chromium.org/16817006/diff/39001/chrome/common/extensions/... File chrome/common/extensions/api/system_info_display.idl (right): https://codereview.chromium.org/16817006/diff/39001/chrome/common/extensions/... chrome/common/extensions/api/system_info_display.idl:82: dictionary SetDisplayUnitInfoParams { nit: let's rename this to something like "DisplayProperties"
https://codereview.chromium.org/16817006/diff/39001/chrome/browser/extensions... File chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc (right): https://codereview.chromium.org/16817006/diff/39001/chrome/browser/extensions... chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc:332: DisplayManager* manager) { On 2013/06/14 16:11:00, Greg Spencer (Chromium) wrote: > indent Done. https://codereview.chromium.org/16817006/diff/39001/chrome/common/extensions/... File chrome/common/extensions/api/system_info_display.idl (right): https://codereview.chromium.org/16817006/diff/39001/chrome/common/extensions/... chrome/common/extensions/api/system_info_display.idl:82: dictionary SetDisplayUnitInfoParams { On 2013/06/14 17:02:59, Antony Sargent wrote: > nit: let's rename this to something like "DisplayProperties" Done.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/16817006/66005
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/16817006/66005
Message was sent while issue was closed.
Change committed as 206576 |
