Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1681683005: Set distribution recalc flag when a slot assignment changes (Closed)

Created:
4 years, 10 months ago by hayato
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set distribution recalc flag when a slot assignment changes We need to set the recalc flag when a slot assignment changes. Unless that, the distributed nodes of a slot in a child tree is not updated. BUG=531990 Committed: https://crrev.com/43dc9606c8ab76d4378d61d964dcac73fd6bb9ca Cr-Commit-Position: refs/heads/master@{#375414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-dynamic.html View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681683005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681683005/1
4 years, 10 months ago (2016-02-09 09:21:54 UTC) #2
hayato
PTAL
4 years, 10 months ago (2016-02-09 09:25:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-09 12:43:24 UTC) #7
hayato
PTAL
4 years, 10 months ago (2016-02-10 11:53:37 UTC) #8
kochi
lgtm
4 years, 10 months ago (2016-02-15 05:18:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681683005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681683005/1
4 years, 10 months ago (2016-02-15 05:59:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 07:24:28 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:48:54 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43dc9606c8ab76d4378d61d964dcac73fd6bb9ca
Cr-Commit-Position: refs/heads/master@{#375414}

Powered by Google App Engine
This is Rietveld 408576698