third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp - Issue 1681663003: Reland Fix leak PaintLayerReflectionInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp

Issue 1681663003: Reland Fix leak PaintLayerReflectionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp b/third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp

index db2a9b84f30d2e2128bf17a59b61f478e73e0b74..7859231c982f5f7827534db08e3062615d136e7f 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.cpp

@@ -65,7 +65,7 @@ PaintLayerReflectionInfo::PaintLayerReflectionInfo(LayoutBox& layoutObject)

m_reflection->setDangerousOneWayParent(m_box);

}

-void PaintLayerReflectionInfo::destroy()

+PaintLayerReflectionInfo::~PaintLayerReflectionInfo()

{

if (!m_reflection->documentBeingDestroyed())

m_reflection->removeLayers(box().layer());