Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.

Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002

Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e

Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4

Committed: https://skia.googlesource.com/skia/+/50a8dd0a00538840e55233146cb202e256cc6c34

[ethannicholas, 2016-02-08 18:13:18]

Description was changed from

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
==========

to

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ethannicholas, 2016-02-08 18:16:45]

ethannicholas@google.com changed reviewers:
+ jcgregorio@google.com, joshualitt@chromium.org

[jcgregorio, 2016-02-08 18:40:02]

https://codereview.chromium.org/1681643002/diff/20001/src/utils/debugger/SkDr...
File src/utils/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/1681643002/diff/20001/src/utils/debugger/SkDr...
src/utils/debugger/SkDrawCommand.cpp:432:
result.append(make_json_point(rrect.radii(SkRRect::kUpperLeft_Corner)));
So an RRect will be encoded as an array of 12 floats?

[ethannicholas, 2016-02-08 18:47:54]

On 2016/02/08 18:40:02, jcgregorio wrote:
>
https://codereview.chromium.org/1681643002/diff/20001/src/utils/debugger/SkDr...
> File src/utils/debugger/SkDrawCommand.cpp (right):
> 
>
https://codereview.chromium.org/1681643002/diff/20001/src/utils/debugger/SkDr...
> src/utils/debugger/SkDrawCommand.cpp:432:
> result.append(make_json_point(rrect.radii(SkRRect::kUpperLeft_Corner)));
> So an RRect will be encoded as an array of 12 floats?

It's actually an array of four floats (LTRB), followed by four arrays of two
floats each (corner radii). The encoding has not changed from before, it's
merely moving into SkDebugCanvas.

[jcgregorio, 2016-02-08 18:53:38]

lgtm

[ethannicholas, 2016-02-08 18:54:44]

The CQ bit was checked by ethannicholas@google.com

[commit-bot: I haz the power, 2016-02-08 18:54:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681643002/20001

[commit-bot: I haz the power, 2016-02-08 19:20:39]

Description was changed from

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
==========

[commit-bot: I haz the power, 2016-02-08 19:20:39]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e

[ethannicholas, 2016-02-08 19:36:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1680853002/ by ethannicholas@google.com.

The reason for reverting is: Breaking cmake build.

[ethannicholas, 2016-02-09 21:54:55]

Description was changed from

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
==========

to

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
==========

[ethannicholas, 2016-02-09 21:55:39]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2016-02-09 21:55:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/1681643002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-02-09 21:55:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681643002/40001

[commit-bot: I haz the power, 2016-02-09 22:37:59]

Description was changed from

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e
==========

to

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e

Committed:
https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4
==========

[commit-bot: I haz the power, 2016-02-09 22:37:59]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4

[caryclark, 2016-02-10 12:33:50]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1683093002/ by caryclark@google.com.

The reason for reverting is: breaks various android builds, e.g.

https://android-build.storage.googleapis.com/builds/git_master-skia-linux-bul...

external/skia/bench/../tools/debugger/SkDrawCommand.cpp:602:9: error: use of
undeclared identifier 'free'
        free(data);
.

[ethannicholas, 2016-02-10 13:12:16]

Description was changed from

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e

Committed:
https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4
==========

to

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e

Committed:
https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4
==========

[ethannicholas, 2016-02-10 13:15:10]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2016-02-10 13:15:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/1681643002/#ps60001
(title: "switched from free to sk_free")

[commit-bot: I haz the power, 2016-02-10 13:15:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681643002/60001

[commit-bot: I haz the power, 2016-02-10 13:40:49]

Description was changed from

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e

Committed:
https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4
==========

to

==========
Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
SkJSONCanvas and SkJSONRenderer will be deleted once the debug server
has been updated.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e

Committed:
https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4

Committed:
https://skia.googlesource.com/skia/+/50a8dd0a00538840e55233146cb202e256cc6c34
==========

[commit-bot: I haz the power, 2016-02-10 13:40:50]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/50a8dd0a00538840e55233146cb202e256cc6c34