Issue 16816016: Fix for PNG, coding style, skip opaque.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16816016: Fix for PNG, coding style, skip opaque. (Closed)

Created:
7 years, 6 months ago by scroggo

Modified:
7 years, 6 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix for PNG, coding style, skip opaque. In PNG decoder, pass the requirement for decoding unpremultiplied to the SkScaledBitmapSampler. In the test, skip formats that are opaque. Label static functions as static, and following coding style for their names. Merged into https://codereview.chromium.org/16410009

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -8 lines)			Patch
M	samplecode/SampleUnpremul.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/images/SkImageDecoder_libpng.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/ImageDecodingTest.cpp	View	4 chunks	+29 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages