runtime/vm/dart_api_impl.cc - Issue 16816007: When unwraping handles, verify only if --verify_handles. Fixes issue 11265,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 16816007: When unwraping handles, verify only if --verify_handles. Fixes issue 11265, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

===================================================================

--- runtime/vm/dart_api_impl.cc (revision 23941)

+++ runtime/vm/dart_api_impl.cc (working copy)

@@ -34,6 +34,7 @@

namespace dart {

DECLARE_FLAG(bool, print_class_table);

+DECLARE_FLAG(bool, verify_handles);

ThreadLocalKey Api::api_native_key_ = Thread::kUnsetThreadLocalKey;

Dart_Handle Api::true_handle_ = NULL;

@@ -97,7 +98,8 @@

ASSERT(isolate != NULL);

ApiState* state = isolate->api_state();

ASSERT(state != NULL);

- ASSERT(state->IsValidLocalHandle(object) ||

+ ASSERT(!FLAG_verify_handles ||

+ state->IsValidLocalHandle(object) ||

Dart::vm_isolate()->api_state()->IsValidLocalHandle(object));

ASSERT(FinalizablePersistentHandle::raw_offset() == 0 &&

PersistentHandle::raw_offset() == 0 &&

« no previous file with comments | « no previous file | no next file » | no next file with comments »