Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1681593004: Fix a couple of references in _runtime that should have been resolved as quasiquotes (Closed)

Created:
4 years, 10 months ago by ochafik
Modified:
4 years, 10 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a couple of references in _runtime that should have been resolved as quasiquotes (found when doing tree-shaking :-)) BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/16f62463296e31cf25e248fde874d9b51b174c81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tool/input_sdk/private/generators.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/private/operations.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tool/input_sdk/private/types.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ochafik
A couple of nits a day, keeps the doctor away.
4 years, 10 months ago (2016-02-09 10:18:21 UTC) #2
Jennifer Messerly
lgtm
4 years, 10 months ago (2016-02-09 16:21:29 UTC) #3
ochafik
4 years, 10 months ago (2016-02-09 16:35:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
16f62463296e31cf25e248fde874d9b51b174c81 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698