third_party/WebKit/Source/core/svg/SVGURIReference.h - Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGURIReference.h

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove invalid assert. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/svg/SVGAnimatedHref.h ('K') | « third_party/WebKit/Source/core/svg/SVGElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGURIReference.cpp » ('j') | third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGURIReference.h

diff --git a/third_party/WebKit/Source/core/svg/SVGURIReference.h b/third_party/WebKit/Source/core/svg/SVGURIReference.h

index b676bd33a1b6a394bf5786108b4f210598539907..dd29ecdfbcfe9430cce9aa8e60e1ae8a97a0a51e 100644

--- a/third_party/WebKit/Source/core/svg/SVGURIReference.h

+++ b/third_party/WebKit/Source/core/svg/SVGURIReference.h

@@ -23,7 +23,7 @@

#include "core/CoreExport.h"

#include "core/dom/Document.h"

-#include "core/svg/SVGAnimatedString.h"

+#include "core/svg/SVGAnimatedHref.h"

#include "platform/heap/Handle.h"

namespace blink {

@@ -54,7 +54,7 @@ public:

const String& hrefString() const { return m_href->currentValue()->value(); }

// JS API

- SVGAnimatedString* href() const { return m_href.get(); }

+ SVGAnimatedHref* href() const { return m_href.get(); }

DECLARE_VIRTUAL_TRACE();

@@ -62,7 +62,7 @@ protected:

explicit SVGURIReference(SVGElement*);

private:

- RefPtrWillBeMember<SVGAnimatedString> m_href;

+ RefPtrWillBeMember<SVGAnimatedHref> m_href;

};

} // namespace blink