third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp - Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove invalid assert. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/dom/href-semantics.html ('K') | « third_party/WebKit/Source/core/dom/VisitedLinkState.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimatedHref.h » ('j') | third_party/WebKit/Source/core/svg/SVGAnimatedHref.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp b/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

index 39a5b57030bd66af99de2d67a89606f54686c9bc..b7c4aaa36e84e512f1eed9a2502a6b2911162e30 100644

--- a/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

+++ b/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp

@@ -491,6 +491,7 @@ bool XSSAuditor::filterScriptToken(const FilterTokenRequest& request)

m_scriptTagFoundInRequest = isContainedInRequest(canonicalizedSnippetForTagName(request));

if (m_scriptTagFoundInRequest) {

didBlockScript |= eraseAttributeIfInjected(request, srcAttr, blankURL().string(), SrcLikeAttributeTruncation);

+ didBlockScript |= eraseAttributeIfInjected(request, SVGNames::hrefAttr, blankURL().string(), SrcLikeAttributeTruncation);

didBlockScript |= eraseAttributeIfInjected(request, XLinkNames::hrefAttr, blankURL().string(), SrcLikeAttributeTruncation);

}

return didBlockScript;