Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase; update comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp
index 22a3cb86a7e697ef6c3640a3219459e67473f8b6..5a55cf203e3dec6ec8cb9bca13e283d47afc1aa5 100644
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -26,7 +26,6 @@
#include "bindings/core/v8/ScriptEventListener.h"
#include "core/HTMLNames.h"
#include "core/SVGNames.h"
-#include "core/XLinkNames.h"
#include "core/XMLNames.h"
#include "core/animation/AnimationStack.h"
#include "core/animation/DocumentAnimations.h"
@@ -1045,7 +1044,6 @@ bool SVGElement::isAnimatableAttribute(const QualifiedName& name) const
if (animatableAttributes.isEmpty()) {
const QualifiedName* const animatableAttrs[] = {
- &XLinkNames::hrefAttr,
&SVGNames::amplitudeAttr,
&SVGNames::azimuthAttr,
&SVGNames::baseFrequencyAttr,
@@ -1066,6 +1064,7 @@ bool SVGElement::isAnimatableAttribute(const QualifiedName& name) const
&SVGNames::gradientTransformAttr,
&SVGNames::gradientUnitsAttr,
&SVGNames::heightAttr,
+ &SVGNames::hrefAttr,
&SVGNames::in2Attr,
&SVGNames::inAttr,
&SVGNames::interceptAttr,
@@ -1178,7 +1177,7 @@ void SVGElement::rebuildAllIncomingReferences()
for (SVGElement* sourceElement : incomingReferencesSnapshot) {
// Before rebuilding |sourceElement| ensure it was not removed from under us.
if (incomingReferences.contains(sourceElement))
- sourceElement->svgAttributeChanged(XLinkNames::hrefAttr);
+ sourceElement->svgAttributeChanged(SVGNames::hrefAttr);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAttributeNames.in ('k') | third_party/WebKit/Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698