Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase; update comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
diff --git a/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp b/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
index 272eb6a302dd2760d3c5f1edf332f061991dc4fd..2105bbad00a0e2ea7f415496373b353144bfd01c 100644
--- a/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
+++ b/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
@@ -5,7 +5,6 @@
#include "core/animation/AnimationInputHelpers.h"
#include "core/SVGNames.h"
-#include "core/XLinkNames.h"
#include "core/css/CSSValueList.h"
#include "core/css/parser/CSSParser.h"
#include "core/css/resolver/CSSToStyleMap.h"
@@ -88,6 +87,7 @@ const AttributeNameMap& getSupportedAttributes()
&SVGNames::gradientTransformAttr,
&SVGNames::gradientUnitsAttr,
&SVGNames::heightAttr,
+ &SVGNames::hrefAttr,
&SVGNames::in2Attr,
&SVGNames::inAttr,
&SVGNames::interceptAttr,
@@ -161,7 +161,6 @@ const AttributeNameMap& getSupportedAttributes()
&SVGNames::yAttr,
&SVGNames::yChannelSelectorAttr,
&SVGNames::zAttr,
- &XLinkNames::hrefAttr,
};
for (size_t i = 0; i < WTF_ARRAY_LENGTH(attributes); i++)
supportedAttributes.set(*attributes[i], attributes[i]);
@@ -172,10 +171,6 @@ const AttributeNameMap& getSupportedAttributes()
QualifiedName svgAttributeName(const String& property)
{
ASSERT(!isSVGPrefixed(property));
-
- if (property == "href")
- return XLinkNames::hrefAttr;
-
return QualifiedName(nullAtom, AtomicString(property), nullAtom);
}

Powered by Google App Engine
This is Rietveld 408576698