Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGURIReference.h

Issue 1681553002: Add support for 'href' (w/o XLink NS) for various SVG elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase; update comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008, 2009 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008, 2009 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 #ifndef SVGURIReference_h 21 #ifndef SVGURIReference_h
22 #define SVGURIReference_h 22 #define SVGURIReference_h
23 23
24 #include "core/CoreExport.h" 24 #include "core/CoreExport.h"
25 #include "core/dom/Document.h" 25 #include "core/dom/Document.h"
26 #include "core/svg/SVGAnimatedString.h" 26 #include "core/svg/SVGAnimatedHref.h"
27 #include "platform/heap/Handle.h" 27 #include "platform/heap/Handle.h"
28 28
29 namespace blink { 29 namespace blink {
30 30
31 class Element; 31 class Element;
32 32
33 class CORE_EXPORT SVGURIReference : public WillBeGarbageCollectedMixin { 33 class CORE_EXPORT SVGURIReference : public WillBeGarbageCollectedMixin {
34 public: 34 public:
35 virtual ~SVGURIReference() { } 35 virtual ~SVGURIReference() { }
36 36
37 bool isKnownAttribute(const QualifiedName&); 37 bool isKnownAttribute(const QualifiedName&);
38 38
39 // Use this for accesses to 'href' or 'xlink:href' (in that order) for
40 // elements where both are allowed and don't necessarily inherit from
41 // SVGURIReference.
42 static const AtomicString& legacyHrefString(const SVGElement&);
43
44 // Like above, but for elements that inherit from SVGURIReference. Resolves
45 // against the base URL of the passed Document.
46 KURL legacyHrefURL(const Document&) const;
47
39 static AtomicString fragmentIdentifierFromIRIString(const String&, const Tre eScope&); 48 static AtomicString fragmentIdentifierFromIRIString(const String&, const Tre eScope&);
40 static Element* targetElementFromIRIString(const String&, const TreeScope&, AtomicString* = 0, Document* = 0); 49 static Element* targetElementFromIRIString(const String&, const TreeScope&, AtomicString* = 0, Document* = 0);
41 50
42 static inline bool isExternalURIReference(const String& uri, const Document& document) 51 static inline bool isExternalURIReference(const String& uri, const Document& document)
43 { 52 {
44 // Fragment-only URIs are always internal if the baseURL is same as the document URL. 53 // Fragment-only URIs are always internal if the baseURL is same as the document URL.
45 // This is common case, so check that first to avoid resolving URL (whic h is relatively expensive). See crbug.com/557979 54 // This is common case, so check that first to avoid resolving URL (whic h is relatively expensive). See crbug.com/557979
46 if (document.baseURL() == document.url() && uri.startsWith('#')) 55 if (document.baseURL() == document.url() && uri.startsWith('#'))
47 return false; 56 return false;
48 57
49 // If the URI matches our documents URL, we're dealing with a local refe rence. 58 // If the URI matches our documents URL, we're dealing with a local refe rence.
50 KURL url = document.completeURL(uri); 59 KURL url = document.completeURL(uri);
51 return !equalIgnoringFragmentIdentifier(url, document.url()); 60 return !equalIgnoringFragmentIdentifier(url, document.url());
52 } 61 }
53 62
54 const String& hrefString() const { return m_href->currentValue()->value(); } 63 const String& hrefString() const { return m_href->currentValue()->value(); }
55 64
56 // JS API 65 // JS API
57 SVGAnimatedString* href() const { return m_href.get(); } 66 SVGAnimatedHref* href() const { return m_href.get(); }
58 67
59 DECLARE_VIRTUAL_TRACE(); 68 DECLARE_VIRTUAL_TRACE();
60 69
61 protected: 70 protected:
62 explicit SVGURIReference(SVGElement*); 71 explicit SVGURIReference(SVGElement*);
63 72
64 private: 73 private:
65 RefPtrWillBeMember<SVGAnimatedString> m_href; 74 RefPtrWillBeMember<SVGAnimatedHref> m_href;
66 }; 75 };
67 76
68 } // namespace blink 77 } // namespace blink
69 78
70 #endif // SVGURIReference_h 79 #endif // SVGURIReference_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGURIReference.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698