Tenure long-living descriptor arrays.

Tenure long-living descriptor arrays.

BUG=chromium:580971
LOG=n

Committed: https://crrev.com/bf521632caa8b83140d01b4d1104733405eb251d
Cr-Commit-Position: refs/heads/master@{#33840}

[Hannes Payer (out of office), 2016-02-08 16:57:50]

hpayer@chromium.org changed reviewers:
+ ishell@chromium.org, ulan@chromium.org

[ulan, 2016-02-08 17:06:22]

lgtm

[Igor Sheludko, 2016-02-08 19:54:03]

https://codereview.chromium.org/1681533003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1681533003/diff/1/src/objects.cc#newcode9470
src/objects.cc:9470: descriptors = DescriptorArray::Allocate(map->GetIsolate(),
0, 1, TENURED);
I would assume that this is very unlikely the object will have only one
property, therefore another will be added and most likely this descriptor will
be replaced with the one we allocate on line 9473.

I would say, not tenure here.

[Hannes Payer (out of office), 2016-02-09 08:05:14]

Thanks for the comment! The rule of thumb is: as long as we add slack to the
descriptor array, we should not tenure because it may change. Makes sense.

[Hannes Payer (out of office), 2016-02-09 08:06:01]

https://codereview.chromium.org/1681533003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1681533003/diff/1/src/objects.cc#newcode9470
src/objects.cc:9470: descriptors = DescriptorArray::Allocate(map->GetIsolate(),
0, 1, TENURED);
On 2016/02/08 19:54:03, Igor Sheludko wrote:
> I would assume that this is very unlikely the object will have only one
> property, therefore another will be added and most likely this descriptor will
> be replaced with the one we allocate on line 9473.
> 
> I would say, not tenure here.

Done.

[Igor Sheludko, 2016-02-09 09:33:43]

lgtm

[Hannes Payer (out of office), 2016-02-09 10:00:10]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2016-02-09 10:00:10]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1681533003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-09 10:00:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681533003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681533003/20001

[commit-bot: I haz the power, 2016-02-09 10:24:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-09 10:25:12]

Description was changed from

==========
Tenure long-living descriptor arrays.

BUG=chromium:580971
LOG=n
==========

to

==========
Tenure long-living descriptor arrays.

BUG=chromium:580971
LOG=n

Committed: https://crrev.com/bf521632caa8b83140d01b4d1104733405eb251d
Cr-Commit-Position: refs/heads/master@{#33840}
==========

[commit-bot: I haz the power, 2016-02-09 10:25:13]

Patchset 2 (id:??) landed as
https://crrev.com/bf521632caa8b83140d01b4d1104733405eb251d
Cr-Commit-Position: refs/heads/master@{#33840}