Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: pkg/analyzer/test/src/task/dart_test.dart

Issue 1681493005: Fix for recording 'null' as a defined element. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/dart_test.dart
diff --git a/pkg/analyzer/test/src/task/dart_test.dart b/pkg/analyzer/test/src/task/dart_test.dart
index a259e62430e8c117d400717f844a9556849a08da..e3b847ba666276f133f7720f22e8deae14e0ceaa 100644
--- a/pkg/analyzer/test/src/task/dart_test.dart
+++ b/pkg/analyzer/test/src/task/dart_test.dart
@@ -2240,6 +2240,8 @@ main() {
@reflectiveTest
class GatherUsedLocalElementsTaskTest extends _AbstractDartTaskTest {
+ List<Element> definedElements;
+ Set<String> definedElementNames;
UsedLocalElements usedElements;
Set<String> usedElementNames;
@@ -2304,6 +2306,7 @@ main() {
}''');
_computeUsedElements(source);
// validate
+ expect(definedElementNames, unorderedEquals(['main', 'v1', 'v2']));
expect(usedElementNames, unorderedEquals(['v2']));
}
@@ -2323,14 +2326,30 @@ main(A a, p) {
''');
_computeUsedElements(source);
// validate
+ expect(definedElementNames,
+ unorderedEquals(['A', '_m1', '_m2', 'main', 'a', 'p']));
expect(usedElementNames, unorderedEquals(['A', 'a', 'p', '_m2']));
expect(usedElements.members, unorderedEquals(['_m2', '_m3']));
}
+ test_perform_unresolvedImportWithPrefix() {
+ Source source = newSource(
+ '/test.dart',
+ r'''
+import 'x' as p;
+''');
+ _computeUsedElements(source);
+ // validate
+ expect(definedElementNames, isEmpty);
+ expect(usedElementNames, isEmpty);
+ }
+
void _computeUsedElements(Source source) {
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
computeResult(target, USED_LOCAL_ELEMENTS,
matcher: isGatherUsedLocalElementsTask);
+ definedElements = outputs[DEFINED_ELEMENTS];
+ definedElementNames = definedElements.map((e) => e.name).toSet();
usedElements = outputs[USED_LOCAL_ELEMENTS];
usedElementNames = usedElements.elements.map((e) => e.name).toSet();
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698