Unit tests for LayoutObject::mapLocalToAncestor() (and overrides).

Unit tests for LayoutObject::mapLocalToAncestor() (and overrides).

BUG=568492
Committed: https://crrev.com/9fc9177179ed5c6bc5e9824c669199c8b15b56e3
Cr-Commit-Position: refs/heads/master@{#375145}

[mstensho (USE GERRIT), 2016-02-11 12:15:57]

mstensho@opera.com changed reviewers:
+ leviw@chromium.org

[mstensho (USE GERRIT), 2016-02-11 12:15:58]

Will write tests for carrots and beer! :)

I really wanted to test scrolling and 3D transforms too, but this proved hard to
do from unit tests. Probably because we don't paint.

[pdr., 2016-02-11 23:25:44]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[pdr., 2016-02-11 23:30:46]

On 2016/02/11 at 12:15:58, mstensho wrote:
> Will write tests for carrots and beer! :)
> 
> I really wanted to test scrolling and 3D transforms too, but this proved hard
to do from unit tests. Probably because we don't paint.

+cc chrishtr just FYI. We don't have any carrots though, only sticks.

[leviw_travelin_and_unemployed, 2016-02-11 23:47:42]

Can you add a link to BUG=568492 to track why I made you embark on this madness
(for pdr and chrishtr, I proposed these tests to ensure we don't break the world
with https://codereview.chromium.org/1516003003).

I pity the paint sticks, but for my part I'll feel a lot more comfortable with
the other patch with this. LGTM.

[chrishtr, 2016-02-12 00:34:50]

On 2016/02/11 at 12:15:58, mstensho wrote:
> Will write tests for carrots and beer! :)
> 
> I really wanted to test scrolling and 3D transforms too, but this proved hard
to do from unit tests. Probably because we don't paint.

That shouldn't matter...what went wrong when you tried it?

[mstensho (USE GERRIT), 2016-02-12 07:43:57]

Description was changed from

==========
Unit tests for LayoutObject::mapLocalToAncestor() (and overrides).
==========

to

==========
Unit tests for LayoutObject::mapLocalToAncestor() (and overrides).

BUG=568492
==========

[mstensho (USE GERRIT), 2016-02-12 07:47:37]

On 2016/02/12 00:34:50, chrishtr wrote:
> On 2016/02/11 at 12:15:58, mstensho wrote:
> > Will write tests for carrots and beer! :)
> > 
> > I really wanted to test scrolling and 3D transforms too, but this proved
hard
> to do from unit tests. Probably because we don't paint.
> 
> That shouldn't matter...what went wrong when you tried it?

PaintLayer::transform() behaved very differently.

I had the same test.html in content_shell as in a unit test, and called
getClientRects(), to trigger calls into mapLocalToAncestor().

[mstensho (USE GERRIT), 2016-02-12 07:49:11]

On 2016/02/11 23:47:42, leviw wrote:
> Can you add a link to BUG=568492 to track why I made you embark on this
madness
> (for pdr and chrishtr, I proposed these tests to ensure we don't break the
world
> with https://codereview.chromium.org/1516003003).

Done.

I'll just land this now. If we figure out to get 3D transforms to behave in unit
tests, I'll upload a separate CL for that.

[mstensho (USE GERRIT), 2016-02-12 07:49:19]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-02-12 07:49:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681403004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681403004/20001

[commit-bot: I haz the power, 2016-02-12 07:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 07:53:37]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[commit-bot: I haz the power, 2016-02-12 07:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[mstensho (USE GERRIT), 2016-02-12 07:55:42]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-02-12 07:56:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681403004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681403004/20001

[commit-bot: I haz the power, 2016-02-12 08:00:40]

Description was changed from

==========
Unit tests for LayoutObject::mapLocalToAncestor() (and overrides).

BUG=568492
==========

to

==========
Unit tests for LayoutObject::mapLocalToAncestor() (and overrides).

BUG=568492
==========

[commit-bot: I haz the power, 2016-02-12 08:00:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:42:16]

Description was changed from

==========
Unit tests for LayoutObject::mapLocalToAncestor() (and overrides).

BUG=568492
==========

to

==========
Unit tests for LayoutObject::mapLocalToAncestor() (and overrides).

BUG=568492

Committed: https://crrev.com/9fc9177179ed5c6bc5e9824c669199c8b15b56e3
Cr-Commit-Position: refs/heads/master@{#375145}
==========

[commit-bot: I haz the power, 2016-02-16 22:42:17]

Patchset 2 (id:??) landed as
https://crrev.com/9fc9177179ed5c6bc5e9824c669199c8b15b56e3
Cr-Commit-Position: refs/heads/master@{#375145}