Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1681393004: WebRTC: Rename libjingle_media_unittest -> rtc_media_unittests (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Rename libjingle_media_unittest -> rtc_media_unittests BUG=webrtc:5420 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298759

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1139 lines, -1139 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json View 23 chunks +53 lines, -53 lines 2 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_ubsan.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac64_release__swarming_.json View 23 chunks +53 lines, -53 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win32_release__swarming_.json View 23 chunks +53 lines, -53 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_full.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_light.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_legacy_svn_patch.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_swarming.json View 23 chunks +53 lines, -53 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_swarming.json View 23 chunks +53 lines, -53 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_full.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_light.json View 10 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json View 23 chunks +53 lines, -53 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json View 5 chunks +20 lines, -20 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json View 5 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kjellander_chromium
See bug for context.
4 years, 10 months ago (2016-02-10 16:34:53 UTC) #2
phoglund_chromium
lgtm, but double check it's just the diff algorithm screwing up since it looks like ...
4 years, 10 months ago (2016-02-11 08:41:12 UTC) #3
kjellander_chromium
https://codereview.chromium.org/1681393004/diff/1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json File scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json (right): https://codereview.chromium.org/1681393004/diff/1/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json#newcode456 scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_release__swarming_.json:456: "libjingle_p2p_unittest/Ubuntu/[dummy has/Linux64 Release (swarming)/1337", On 2016/02/11 08:41:12, phoglund_chrome wrote: ...
4 years, 10 months ago (2016-02-11 09:29:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681393004/1
4 years, 10 months ago (2016-02-11 09:30:36 UTC) #6
commit-bot: I haz the power
Dry run: SVN-based build project isn't mirrored to Git currently, so we disabled CQ. See ...
4 years, 10 months ago (2016-02-11 09:32:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681393004/1
4 years, 10 months ago (2016-02-12 13:55:35 UTC) #10
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-12 13:58:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681393004/1
4 years, 10 months ago (2016-02-12 14:00:58 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 14:03:49 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298759

Powered by Google App Engine
This is Rietveld 408576698