Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4134)

Unified Diff: cc/scheduler/compositor_timing_history_unittest.cc

Issue 1681393003: cc: Add MainAndImplFrameTimeDelta UMA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - active_tree_needs_first_draw_ = true Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/compositor_timing_history.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/compositor_timing_history_unittest.cc
diff --git a/cc/scheduler/compositor_timing_history_unittest.cc b/cc/scheduler/compositor_timing_history_unittest.cc
index 900367f14ec5152c2502b73118da017b7328cf66..f57d44340c5a3a51b83472e2378afdbaea6d9a76 100644
--- a/cc/scheduler/compositor_timing_history_unittest.cc
+++ b/cc/scheduler/compositor_timing_history_unittest.cc
@@ -17,7 +17,8 @@ class TestCompositorTimingHistory : public CompositorTimingHistory {
public:
TestCompositorTimingHistory(CompositorTimingHistoryTest* test,
RenderingStatsInstrumentation* rendering_stats)
- : CompositorTimingHistory(NULL_UMA, rendering_stats), test_(test) {}
+ : CompositorTimingHistory(false, NULL_UMA, rendering_stats),
+ test_(test) {}
protected:
base::TimeTicks Now() const override;
@@ -68,7 +69,7 @@ TEST_F(CompositorTimingHistoryTest, AllSequential_Commit) {
base::TimeDelta activate_duration = base::TimeDelta::FromMilliseconds(4);
base::TimeDelta draw_duration = base::TimeDelta::FromMilliseconds(5);
- timing_history_.WillBeginMainFrame(true);
+ timing_history_.WillBeginMainFrame(true, Now());
AdvanceNowBy(begin_main_frame_queue_duration);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_commit_duration);
@@ -87,7 +88,7 @@ TEST_F(CompositorTimingHistoryTest, AllSequential_Commit) {
AdvanceNowBy(one_second);
timing_history_.WillDraw();
AdvanceNowBy(draw_duration);
- timing_history_.DidDraw(true);
+ timing_history_.DidDraw(true, true, Now());
EXPECT_EQ(begin_main_frame_queue_duration,
timing_history_.BeginMainFrameQueueDurationCriticalEstimate());
@@ -126,7 +127,7 @@ TEST_F(CompositorTimingHistoryTest, AllSequential_BeginMainFrameAborted) {
base::TimeDelta activate_duration = base::TimeDelta::FromMilliseconds(4);
base::TimeDelta draw_duration = base::TimeDelta::FromMilliseconds(5);
- timing_history_.WillBeginMainFrame(true);
+ timing_history_.WillBeginMainFrame(false, Now());
AdvanceNowBy(begin_main_frame_queue_duration);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_commit_duration);
@@ -146,9 +147,9 @@ TEST_F(CompositorTimingHistoryTest, AllSequential_BeginMainFrameAborted) {
AdvanceNowBy(one_second);
timing_history_.WillDraw();
AdvanceNowBy(draw_duration);
- timing_history_.DidDraw(true);
+ timing_history_.DidDraw(false, false, Now());
- EXPECT_EQ(begin_main_frame_queue_duration,
+ EXPECT_EQ(base::TimeDelta(),
timing_history_.BeginMainFrameQueueDurationCriticalEstimate());
EXPECT_EQ(begin_main_frame_queue_duration,
timing_history_.BeginMainFrameQueueDurationNotCriticalEstimate());
@@ -179,13 +180,13 @@ TEST_F(CompositorTimingHistoryTest, BeginMainFrame_CriticalFaster) {
base::TimeDelta begin_main_frame_start_to_commit_duration =
base::TimeDelta::FromMilliseconds(1);
- timing_history_.WillBeginMainFrame(true);
+ timing_history_.WillBeginMainFrame(true, Now());
AdvanceNowBy(begin_main_frame_queue_duration_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_commit_duration);
timing_history_.BeginMainFrameAborted();
- timing_history_.WillBeginMainFrame(false);
+ timing_history_.WillBeginMainFrame(false, Now());
AdvanceNowBy(begin_main_frame_queue_duration_not_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_commit_duration);
@@ -219,7 +220,7 @@ TEST_F(CompositorTimingHistoryTest, BeginMainFrames_OldCriticalSlower) {
base::TimeDelta::FromMilliseconds(1);
// A single critical frame that is slow.
- timing_history_.WillBeginMainFrame(true);
+ timing_history_.WillBeginMainFrame(true, Now());
AdvanceNowBy(begin_main_frame_queue_duration_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_commit_duration);
@@ -228,7 +229,7 @@ TEST_F(CompositorTimingHistoryTest, BeginMainFrames_OldCriticalSlower) {
// A bunch of faster non critical frames that are newer.
for (int i = 0; i < 100; i++) {
- timing_history_.WillBeginMainFrame(false);
+ timing_history_.WillBeginMainFrame(false, Now());
AdvanceNowBy(begin_main_frame_queue_duration_not_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_commit_duration);
@@ -265,7 +266,7 @@ TEST_F(CompositorTimingHistoryTest, BeginMainFrames_NewCriticalSlower) {
base::TimeDelta::FromMilliseconds(1);
// A single non critical frame that is fast.
- timing_history_.WillBeginMainFrame(false);
+ timing_history_.WillBeginMainFrame(false, Now());
AdvanceNowBy(begin_main_frame_queue_duration_not_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_commit_duration);
@@ -273,7 +274,7 @@ TEST_F(CompositorTimingHistoryTest, BeginMainFrames_NewCriticalSlower) {
// A bunch of slower critical frames that are newer.
for (int i = 0; i < 100; i++) {
- timing_history_.WillBeginMainFrame(true);
+ timing_history_.WillBeginMainFrame(true, Now());
AdvanceNowBy(begin_main_frame_queue_duration_critical);
timing_history_.BeginMainFrameStarted(Now());
AdvanceNowBy(begin_main_frame_start_to_commit_duration);
« no previous file with comments | « cc/scheduler/compositor_timing_history.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698