device/usb/usb_device_impl.h - Issue 1681383002: Add path open errors from the permission broker to the device log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_device_impl.h

Issue 1681383002: Add path open errors from the permission broker to the device log. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_request_access

Patch Set: Addresses stevenjb@'s comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/usb_device_impl.h

diff --git a/device/usb/usb_device_impl.h b/device/usb/usb_device_impl.h

index e41dac090f8e8b0f5269f15ad7ce0cd5b157faf1..40bfd1ec345a5803117be0b2fae701cdc42cf130 100644

--- a/device/usb/usb_device_impl.h

+++ b/device/usb/usb_device_impl.h

@@ -97,6 +97,9 @@ class UsbDeviceImpl : public UsbDevice {

#if defined(OS_CHROMEOS)

void OnOpenRequestComplete(const OpenCallback& callback,

dbus::FileDescriptor fd);

+ void OnOpenRequestError(const OpenCallback& callback,

+ const std::string& error_name,

+ const std::string& error_message);

void OpenOnBlockingThreadWithFd(dbus::FileDescriptor fd,

const OpenCallback& callback);

#endif

« no previous file with comments | « device/serial/serial_io_handler.cc ('k') | device/usb/usb_device_impl.cc » ('j') | no next file with comments »