chromeos/dbus/fake_permission_broker_client.h - Issue 1681383002: Add path open errors from the permission broker to the device log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_permission_broker_client.h

Issue 1681383002: Add path open errors from the permission broker to the device log. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_request_access

Patch Set: Addresses stevenjb@'s comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/dbus/fake_permission_broker_client.h

diff --git a/chromeos/dbus/fake_permission_broker_client.h b/chromeos/dbus/fake_permission_broker_client.h

index ee46101f9b4a00ee3aed73c755521e5283ed68a4..3ce911189e92380cddeec051ed79516a8bbbf307 100644

--- a/chromeos/dbus/fake_permission_broker_client.h

+++ b/chromeos/dbus/fake_permission_broker_client.h

@@ -23,7 +23,8 @@ class CHROMEOS_EXPORT FakePermissionBrokerClient

void CheckPathAccess(const std::string& path,

const ResultCallback& callback) override;

void OpenPath(const std::string& path,

- const OpenPathCallback& callback) override;

+ const OpenPathCallback& callback,

+ const ErrorCallback& error_callback) override;

void RequestTcpPortAccess(uint16_t port,

const std::string& interface,

const dbus::FileDescriptor& lifeline_fd,

« no previous file with comments | « no previous file | chromeos/dbus/fake_permission_broker_client.cc » ('j') | no next file with comments »