Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 16813002: Make constant propagation to fold x == x and re-run type propagation for better range analysis. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 23898)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -269,8 +269,6 @@
LocationSummary* EqualityCompareInstr::MakeLocationSummary() const {
const intptr_t kNumInputs = 2;
- const bool is_checked_strict_equal =
- HasICData() && ic_data()->AllTargetsHaveSameOwner(kInstanceCid);
if (receiver_class_id() == kMintCid) {
const intptr_t kNumTemps = 1;
LocationSummary* locs =
@@ -304,7 +302,7 @@
locs->set_out(Location::RequiresRegister());
return locs;
}
- if (is_checked_strict_equal) {
+ if (is_checked_strict_equal()) {
const intptr_t kNumTemps = 1;
LocationSummary* locs =
new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
@@ -843,9 +841,7 @@
EmitDoubleComparisonOp(compiler, *locs(), kind(), kNoBranch);
return;
}
- const bool is_checked_strict_equal =
- HasICData() && ic_data()->AllTargetsHaveSameOwner(kInstanceCid);
- if (is_checked_strict_equal) {
+ if (is_checked_strict_equal()) {
EmitCheckedStrictEqual(compiler, *ic_data(), *locs(), kind(), kNoBranch,
deopt_id());
return;
@@ -885,9 +881,7 @@
EmitDoubleComparisonOp(compiler, *locs(), kind(), branch);
return;
}
- const bool is_checked_strict_equal =
- HasICData() && ic_data()->AllTargetsHaveSameOwner(kInstanceCid);
- if (is_checked_strict_equal) {
+ if (is_checked_strict_equal()) {
EmitCheckedStrictEqual(compiler, *ic_data(), *locs(), kind(), branch,
deopt_id());
return;

Powered by Google App Engine
This is Rietveld 408576698