third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 1681273003: Add CSS parser support for break-after, break-before and break-inside.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 1681273003: Add CSS parser support for break-after, break-before and break-inside. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update some text expectations, and move the new properties into ComputedStyle, since they aren't ra… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt ('k') | third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h » ('j') | third_party/WebKit/Source/core/css/CSSValueKeywords.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

index 0c3dda6c8401ab771c079841d111cfb583c0b6a5..aff50dd1f061fd2f8746f990b940c8de3f9d45df 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -88,6 +88,9 @@ static const CSSPropertyID staticComputableProperties[] = {

CSSPropertyBottom,

CSSPropertyBoxShadow,

CSSPropertyBoxSizing,

+ CSSPropertyBreakAfter,

+ CSSPropertyBreakBefore,

+ CSSPropertyBreakInside,

CSSPropertyCaptionSide,

CSSPropertyClear,

CSSPropertyClip,

@@ -146,9 +149,6 @@ static const CSSPropertyID staticComputableProperties[] = {

CSSPropertyPaddingLeft,

CSSPropertyPaddingRight,

CSSPropertyPaddingTop,

- CSSPropertyPageBreakAfter,

- CSSPropertyPageBreakBefore,

- CSSPropertyPageBreakInside,

CSSPropertyPointerEvents,

CSSPropertyPosition,

CSSPropertyResize,

@@ -208,9 +208,6 @@ static const CSSPropertyID staticComputableProperties[] = {

CSSPropertyWebkitBoxPack,

CSSPropertyWebkitBoxReflect,

CSSPropertyWebkitClipPath,

- CSSPropertyWebkitColumnBreakAfter,

- CSSPropertyWebkitColumnBreakBefore,

- CSSPropertyWebkitColumnBreakInside,

CSSPropertyWebkitColumnCount,

CSSPropertyWebkitColumnGap,

CSSPropertyWebkitColumnRuleColor,