Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 1681273002: MIPS: Mark null and undefined as undetectable, and use it to handle abstract equality comparison in… (Closed)

Created:
4 years, 10 months ago by balazs.kilvady
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Mark null and undefined as undetectable, and use it to handle abstract equality comparison in the generic compare ic. Port for https://codereview.chromium.org/1683643002/ Original commit message: Marking as undetectable makes abstract equality of null, undefined, and other undetectable objects easier. Supporting it in the generic compare IC significantly speeds up dynamic comparison between those values and JSReceivers by not falling back to the runtime. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -52 lines) Patch
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +31 lines, -21 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +31 lines, -21 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
balazs.kilvady
Description was changed from ========== MIPS: Mark null and undefined as undetectable, and use it ...
4 years, 10 months ago (2016-02-09 19:55:55 UTC) #1
balazs.kilvady
4 years, 10 months ago (2016-02-09 19:55:55 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698