Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: build/common.gypi

Issue 1681263003: metrics: Add leak detector controller in Chrome OS metrics system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments, updated LeakDetector with default constructor Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 40bb44ed5ce810f947856024d47bacd62b68d2d6..3fecc15b780f94db4c6833db1f1f5b6c8ee86e4a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1588,6 +1588,9 @@
'libjpeg_ijg_gyp_path': '<(DEPTH)/third_party/libjpeg/libjpeg.gyp',
'libjpeg_turbo_gyp_path': '<(DEPTH)/third_party/libjpeg_turbo/libjpeg.gyp',
+ # Enable runtime memory leak detector.
+ 'enable_leak_detector%': 0,
+
'conditions': [
['buildtype=="Official"', {
# Continue to embed build meta data in Official builds, basically the
@@ -3082,6 +3085,9 @@
'SAFE_BROWSING_DB_REMOTE',
],
}],
+ ['enable_leak_detector==1 and chromeos==1', {
+ 'defines': ['ENABLE_LEAK_DETECTOR=1'],
+ }],
], # conditions for 'target_defaults'
'target_conditions': [
['<(use_libpci)==1', {
@@ -3855,6 +3861,11 @@
'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],
'defines': ['NO_UNWIND_TABLES'],
}],
+ ['enable_leak_detector==1 and chromeos==1', {
+ 'cflags': [
+ '-fno-omit-frame-pointer',
+ ],
+ }],
],
},
},
« no previous file with comments | « no previous file | chrome/browser/metrics/chromeos_metrics_provider.h » ('j') | chrome/browser/metrics/leak_detector_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698