Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: components/metrics/leak_detector/leak_detector.cc

Issue 1681263003: metrics: Add leak detector controller in Chrome OS metrics system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add dep for test_browser_thread_bundle; Use FRIEND_TEST_ALL_PREFIXES Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/leak_detector/leak_detector.cc
diff --git a/components/metrics/leak_detector/leak_detector.cc b/components/metrics/leak_detector/leak_detector.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a7d1149e67707d3818c0e22b1abd48ad7bdddeec
--- /dev/null
+++ b/components/metrics/leak_detector/leak_detector.cc
@@ -0,0 +1,52 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/metrics/leak_detector/leak_detector.h"
+
+#include <algorithm>
+
+#include "content/public/browser/browser_thread.h"
+
+namespace metrics {
+
+LeakDetector::LeakReport::LeakReport() {}
+
+LeakDetector::LeakReport::~LeakReport() {}
+
+LeakDetector::LeakDetector(float sampling_rate,
+ int max_stack_depth,
jochen (gone - plz use gerrit) 2016/02/24 08:05:22 what does a negative value mean here?
Simon Que 2016/02/24 21:28:34 Changed to size_t.
+ uint64_t analysis_interval_bytes,
+ int size_suspicion_threshold,
+ int call_stack_suspicion_threshold)
jochen (gone - plz use gerrit) 2016/02/24 08:05:22 and for those two? what do those values mean anywa
Simon Que 2016/02/24 21:28:34 See comment in header file for meaning. Changed t
+ : weak_factory_(this) {}
+
+LeakDetector::LeakDetector() : LeakDetector(1.0f, 4, 32 * 1024 * 1024, 4, 4) {}
jochen (gone - plz use gerrit) 2016/02/24 08:05:22 can you please define constants for these values,
Simon Que 2016/02/24 21:28:35 Done.
+
+LeakDetector::~LeakDetector() {}
+
+void LeakDetector::AddObserver(Observer* observer) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ observers_.AddObserver(observer);
+}
+
+void LeakDetector::RemoveObserver(Observer* observer) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ observers_.RemoveObserver(observer);
+}
+
+void LeakDetector::NotifyObservers(const std::vector<LeakReport>& reports) {
+ if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
+ content::BrowserThread::PostTask(
+ content::BrowserThread::UI, FROM_HERE,
+ base::Bind(&LeakDetector::NotifyObservers, weak_factory_.GetWeakPtr(),
+ reports));
+ return;
+ }
+
+ for (const LeakReport& report : reports) {
+ FOR_EACH_OBSERVER(Observer, observers_, OnLeakFound(report));
+ }
+}
+
+} // namespace metrics
« no previous file with comments | « components/metrics/leak_detector/leak_detector.h ('k') | components/metrics/leak_detector/leak_detector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698