chrome/browser/metrics/chromeos_metrics_provider.cc - Issue 1681263003: metrics: Add leak detector controller in Chrome OS metrics system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chromeos_metrics_provider.cc

Issue 1681263003: metrics: Add leak detector controller in Chrome OS metrics system (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add dep for test_browser_thread_bundle; Use FRIEND_TEST_ALL_PREFIXES Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chromeos_metrics_provider.h ('k') | chrome/browser/metrics/leak_detector_controller.h » ('j') | components/metrics/leak_detector/leak_detector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chromeos_metrics_provider.cc

diff --git a/chrome/browser/metrics/chromeos_metrics_provider.cc b/chrome/browser/metrics/chromeos_metrics_provider.cc

index fae556025bb6d18a8e6044cdd4854ee3d803b3da..f5eaa21c2b395fcb06171bd31c45c66957f340a9 100644

--- a/chrome/browser/metrics/chromeos_metrics_provider.cc

+++ b/chrome/browser/metrics/chromeos_metrics_provider.cc

@@ -6,13 +6,16 @@

#include <stddef.h>

+#include "base/feature_list.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"

+#include "chrome/common/chrome_features.h"

#include "chrome/common/pref_names.h"

#include "chromeos/system/statistics_provider.h"

+#include "components/metrics/leak_detector/leak_detector.h"

#include "components/metrics/metrics_service.h"

#include "components/metrics/proto/chrome_user_metrics_extension.pb.h"

#include "components/prefs/pref_registry_simple.h"

@@ -141,6 +144,10 @@ ChromeOSMetricsProvider::GetEnrollmentStatus() {

void ChromeOSMetricsProvider::Init() {

perf_provider_.Init();

+ if (base::FeatureList::IsEnabled(features::kRuntimeMemoryLeakDetector)) {

+ leak_detector_controller_.reset(new metrics::LeakDetectorController);

+ }

}

void ChromeOSMetricsProvider::OnDidCreateMetricsLog() {