Android Add java_group() template to GN

Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled (because write_build_config requires that all deps also produce
build_configs)

This adds java_group() in order to fill that gap.

BUG=586506
Committed: https://crrev.com/e70a039356c70a5e4727194283d7b6d844e53331
Cr-Commit-Position: refs/heads/master@{#375249}

[agrieve, 2016-02-12 01:55:17]

Description was changed from

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled.

This adds java_group() in order to fill that gap.

BUG=none
==========

to

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled.

This adds java_group() in order to fill that gap.

BUG=none
==========

[agrieve, 2016-02-12 01:55:17]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[agrieve, 2016-02-12 01:56:00]

On 2016/02/12 01:55:17, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pkotwicz@chromium.org

⚡⚡

[agrieve, 2016-02-12 01:56:28]

On 2016/02/12 01:56:00, agrieve wrote:
> On 2016/02/12 01:55:17, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:pkotwicz@chromium.org
> 
> ⚡⚡

The motivating use: https://codereview.chromium.org/1693463004

[pkotwicz, 2016-02-12 03:10:13]

This definitely deserves a crbug

[agrieve, 2016-02-12 15:14:04]

Description was changed from

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled.

This adds java_group() in order to fill that gap.

BUG=none
==========

to

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled.

This adds java_group() in order to fill that gap.

BUG=586506
==========

[agrieve, 2016-02-12 15:14:10]

On 2016/02/12 03:10:13, pkotwicz wrote:
> This definitely deserves a crbug

Done

[pkotwicz, 2016-02-12 16:19:02]

LGTM

Please comment in the CL description why the dep is not added. It took me a
while to figure it out. My understanding is that the "write_build_config" GN
rule checks whether each of the deps it is passed is one of the types that
write_build_config.py knows about. If it is not one of the types that
write_build_config.py knows about, it completely ignores the dep

[pkotwicz, 2016-02-12 16:19:06]

LGTM

Please comment in the CL description why the dep is not added. It took me a
while to figure it out. My understanding is that the "write_build_config" GN
rule checks whether each of the deps it is passed is one of the types that
write_build_config.py knows about. If it is not one of the types that
write_build_config.py knows about, it completely ignores the dep

[agrieve, 2016-02-12 16:22:42]

Description was changed from

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled.

This adds java_group() in order to fill that gap.

BUG=586506
==========

to

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled (because write_build_config requires that all deps also produce
build_configs)

This adds java_group() in order to fill that gap.

BUG=586506
==========

[agrieve, 2016-02-12 16:22:50]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-02-12 16:22:56]

On 2016/02/12 16:19:06, pkotwicz wrote:
> LGTM
> 
> Please comment in the CL description why the dep is not added. It took me a
> while to figure it out. My understanding is that the "write_build_config" GN
> rule checks whether each of the deps it is passed is one of the types that
> write_build_config.py knows about. If it is not one of the types that
> write_build_config.py knows about, it completely ignores the dep

Done

[commit-bot: I haz the power, 2016-02-12 16:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681223007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681223007/20001

[commit-bot: I haz the power, 2016-02-12 16:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-12 16:29:32]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[agrieve, 2016-02-12 18:19:13]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-12 18:19:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1681223007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1681223007/20001

[commit-bot: I haz the power, 2016-02-12 20:44:00]

Description was changed from

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled (because write_build_config requires that all deps also produce
build_configs)

This adds java_group() in order to fill that gap.

BUG=586506
==========

to

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled (because write_build_config requires that all deps also produce
build_configs)

This adds java_group() in order to fill that gap.

BUG=586506
==========

[commit-bot: I haz the power, 2016-02-12 20:44:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:44:57]

Description was changed from

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled (because write_build_config requires that all deps also produce
build_configs)

This adds java_group() in order to fill that gap.

BUG=586506
==========

to

==========
Android Add java_group() template to GN

One drawback of the custom java_* and android_* GN templates is that
group() does not work as you'd expect. For example, if you have a
dependency like: java_binary() -> group() -> java_library(), then the
java_library() won't actually be added to the java_binary() when
compiled (because write_build_config requires that all deps also produce
build_configs)

This adds java_group() in order to fill that gap.

BUG=586506

Committed: https://crrev.com/e70a039356c70a5e4727194283d7b6d844e53331
Cr-Commit-Position: refs/heads/master@{#375249}
==========

[commit-bot: I haz the power, 2016-02-16 22:44:58]

Patchset 2 (id:??) landed as
https://crrev.com/e70a039356c70a5e4727194283d7b6d844e53331
Cr-Commit-Position: refs/heads/master@{#375249}