Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1681223004: [NaCl SDK] kernel_wrap_tests: Setup munmap mocks before calling ki_init (Closed)

Created:
4 years, 10 months ago by binji
Modified:
4 years, 10 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] kernel_wrap_tests: Setup munmap mocks before calling ki_init If munmap is called during ki_init() in a kernel_wrap_test, it will print a message saying the call was unexpected. This will cause a deadlock since it is trying to print a message inside the memory allocator. BUG=378596 R=sbc@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/65d5a9e415f3f7357677ee40864d3c3d61ba5f6c Cr-Commit-Position: refs/heads/master@{#374745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
binji
4 years, 10 months ago (2016-02-10 19:57:17 UTC) #2
Sam Clegg
Maybe re-enable the test that was disabled pending the fix of 378596? otherwise lgtm
4 years, 10 months ago (2016-02-10 20:15:04 UTC) #3
binji
On 2016/02/10 20:15:04, Sam Clegg wrote: > Maybe re-enable the test that was disabled pending ...
4 years, 10 months ago (2016-02-10 20:32:49 UTC) #4
Sam Clegg
lgtm
4 years, 10 months ago (2016-02-10 20:46:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681223004/1
4 years, 10 months ago (2016-02-10 20:48:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 22:11:55 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65d5a9e415f3f7357677ee40864d3c3d61ba5f6c
Cr-Commit-Position: refs/heads/master@{#374745}

Powered by Google App Engine
This is Rietveld 408576698