Make some HTTP utility functions public

sdk/lib/core/uri.dart

Index: sdk/lib/core/uri.dart
diff --git a/sdk/lib/core/uri.dart b/sdk/lib/core/uri.dart
index 75bd21407c59a215b233d8148e147100c0edf590..135d291d96ebee4b168f279018d910fbe7ea8add 100644
--- a/sdk/lib/core/uri.dart
+++ b/sdk/lib/core/uri.dart
@@ -107,7 +107,7 @@ class Uri {
          query: _emptyIfNull(m[_COMPONENT_QUERY_DATA]),
          fragment: _emptyIfNull(m[_COMPONENT_FRAGMENT]));
 
-  /*
+  /**
    * Create a new URI from its components.
    *
    * Each component is set through a named argument. Any number of
@@ -177,7 +177,7 @@ class Uri {
     _path = _makePath(path, pathSegments);
   }
 
-  /*
+  /**
    * Returns the URI path split into its segments. Each of the
    * segments in the returned list have been decoded. If the path is
    * empty the empty list will be returned. A leading slash `/` does
@@ -200,30 +200,22 @@ class Uri {
     return _pathSegments;
   }
 
-  /*
+  /**
    * Returns the URI query split into a map according to the rules
-   * specified for FORM post in the HTML 4.01 specification. Each key
-   * and value in the returned map have been decoded. If there is no
-   * query the empty map will be returned.
+   * specified for FORM post in the [HTML 4.01 specification section 17.13.4]
+   * (http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4
+   * "HTML 4.01 section 17.13.4"). Each key and value in the returned map
+   * have been decoded. If there is no query the empty map will be returned.

[floitsch, 2013/06/12 11:59:06]

has been decoded. If there is no query the empty map is returned.

[Søren Gjesse, 2013/06/12 12:16:00]

Done.

+   *
+   * If there are keys in the query string without a value the value in

[floitsch, 2013/06/12 11:59:06]

The map contains empty strings for keys in the query that have no value.
or
Keys in the query string that have no value are mapped to the empty string.

?

[Søren Gjesse, 2013/06/12 12:16:00]

Used "Keys in the query string that have no value are mapped to the empty
string." which was much better.

+   * the map for these keys will be the empty string.
    *
    * The returned map is unmodifiable and will throw [UnsupportedError] on any
    * calls that would mutate it.
    */
   Map<String, String> get queryParameters {
     if (_queryParameters == null) {
-      var map;
-      map = query.split("&").fold({}, (map, element) {
-        int index = element.indexOf("=");
-        if (index == -1) {
-          if (!element.isEmpty) map[decodeQueryComponent(element)] = "";
-        } else if (index != 0) {
-          var key = element.substring(0, index);
-          var value = element.substring(index + 1);
-          map[Uri.decodeQueryComponent(key)] = decodeQueryComponent(value);
-        }
-        return map;
-      });
-      _queryParameters = new _UnmodifiableMap(map);
+      _queryParameters = new _UnmodifiableMap(splitQueryString(query));
     }
     return _queryParameters;
   }
@@ -549,6 +541,9 @@ class Uri {
                    fragment: reference.fragment);
   }
 
+  /**
+   * Returns whether the URI has an [authority] component.
+   */
   bool get hasAuthority => host != "";
 
   /**
@@ -647,7 +642,7 @@ class Uri {
     return _uriEncode(_unreserved2396Table, component);
   }
 
-  /*
+  /**
    * Encode the string [component] according to the HTML 4.01 rules
    * for encoding the posting of a HTML form as a query string
    * component.
@@ -718,6 +713,32 @@ class Uri {
     return _uriDecode(uri);
   }
 
+  /**
+   * Returns the [query] split into a map according to the rules
+   * specified for FORM post in the
+   * [HTML 4.01 specification section 17.13.4]
+   * (http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.13.4
+   * "HTML 4.01 section 17.13.4"). Each key and value in the returned
+   * map have been decoded. If the [query]

[floitsch, 2013/06/12 11:59:06]

has been decoded. If the [query] is the empty string an empty map is returned.

[Søren Gjesse, 2013/06/12 12:16:00]

Done.

+   * is the empty string an empty map will be returned.
+   *
+   * If there are keys in the query string without a value the value in

[floitsch, 2013/06/12 11:59:06]

see above.

[Søren Gjesse, 2013/06/12 12:16:00]

Done.

+   * the map for these keys will be the empty string.
+   */
+  static Map<String, String> splitQueryString(String query) {
+    return query.split("&").fold({}, (map, element) {
+      int index = element.indexOf("=");
+      if (index == -1) {
+        if (!element.isEmpty) map[decodeQueryComponent(element)] = "";

[floitsch, 2013/06/12 11:59:06]

I prefer `element != ""` but I'm ok with 'isEmpty'.

[Søren Gjesse, 2013/06/12 12:16:00]

Done.

[Lasse Reichstein Nielsen, 2013/06/13 11:38:27]

What about element.isNotEmpty?

[Søren Gjesse, 2013/06/13 12:00:53]

Using element != "".

+      } else if (index != 0) {
+        var key = element.substring(0, index);
+        var value = element.substring(index + 1);
+        map[Uri.decodeQueryComponent(key)] = decodeQueryComponent(value);
+      }
+      return map;
+    });
+  }
+
   // Frequently used character codes.
   static const int _PERCENT = 0x25;
   static const int _PLUS = 0x2B;