Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: PRESUBMIT.py

Issue 1681173002: Fork //base/gtest_prod_util.h into //mojo/edk/util/gtest_prod_utils.h. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/edk/system/channel_endpoint_id.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 # Make sure that gtest's FRIEND_TEST() macro is not used; the 60 # Make sure that gtest's FRIEND_TEST() macro is not used; the
61 # FRIEND_TEST_ALL_PREFIXES() macro from base/gtest_prod_util.h should be 61 # FRIEND_TEST_ALL_PREFIXES() macro from base/gtest_prod_util.h should be
62 # used instead since that allows for FLAKY_ and DISABLED_ prefixes. 62 # used instead since that allows for FLAKY_ and DISABLED_ prefixes.
63 ( 63 (
64 'FRIEND_TEST(', 64 'FRIEND_TEST(',
65 ( 65 (
66 'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include', 66 'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include',
67 'base/gtest_prod_util.h and use FRIEND_TEST_ALL_PREFIXES() instead.', 67 'base/gtest_prod_util.h and use FRIEND_TEST_ALL_PREFIXES() instead.',
68 ), 68 ),
69 False, 69 False,
70 (), 70 (
71 r"^mojo/edk/util/gtest_prod_utils\.h$",
72 ),
71 ), 73 ),
72 ( 74 (
73 'ScopedAllowIO', 75 'ScopedAllowIO',
74 ( 76 (
75 'New code should not use ScopedAllowIO. Post a task to the blocking', 77 'New code should not use ScopedAllowIO. Post a task to the blocking',
76 'pool or the FILE thread instead.', 78 'pool or the FILE thread instead.',
77 ), 79 ),
78 True, 80 True,
79 ( 81 (
80 r"^base/process/process_metrics_linux\.cc$", 82 r"^base/process/process_metrics_linux\.cc$",
(...skipping 1067 matching lines...) Expand 10 before | Expand all | Expand 10 after
1148 'Mojo Linux ASan Try', 1150 'Mojo Linux ASan Try',
1149 'Mojo Linux Try', 1151 'Mojo Linux Try',
1150 ] 1152 ]
1151 1153
1152 return GetDefaultTryConfigs(builders) 1154 return GetDefaultTryConfigs(builders)
1153 1155
1154 def PostUploadHook(cl, change, output_api): 1156 def PostUploadHook(cl, change, output_api):
1155 import subprocess 1157 import subprocess
1156 subprocess.check_call(["git", "cl", "try"]) 1158 subprocess.check_call(["git", "cl", "try"])
1157 return [] 1159 return []
OLDNEW
« no previous file with comments | « no previous file | mojo/edk/system/channel_endpoint_id.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698