Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1681143003: [TypeFeedbackVector/Crankshaft] Fix private symbol feedback. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TypeFeedbackVector/Crankshaft] Fix private symbol feedback. This reduces runtime of https://github.com/kpdecker/six-speed/blob/master/tests/for-of-array/for-of-array.es6 by 40%. BUG= Committed: https://crrev.com/83c66d8222a05319b7f30aeef28dc8f587b2fe00 Cr-Commit-Position: refs/heads/master@{#33868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-10 13:44:18 UTC) #2
mvstanton
Yep, LGTM.
4 years, 10 months ago (2016-02-10 13:46:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681143003/1
4 years, 10 months ago (2016-02-10 13:48:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 14:12:09 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 14:12:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83c66d8222a05319b7f30aeef28dc8f587b2fe00
Cr-Commit-Position: refs/heads/master@{#33868}

Powered by Google App Engine
This is Rietveld 408576698