chrome/browser/notifications/platform_notification_service_unittest.cc - Issue 1681123002: Plumb Notification action icons through to the UI layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_unittest.cc

Issue 1681123002: Plumb Notification action icons through to the UI layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ActionIconResourceFetching

Patch Set: Rebase. Appease FindBugs some more. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « chrome/browser/notifications/platform_notification_service_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_unittest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_unittest.cc b/chrome/browser/notifications/platform_notification_service_unittest.cc

index 7e53f527a09d650526855e43f0a3084a390b2c0e..ed51422fe363507c45796c9a5a6ab5c3c806e6da 100644

--- a/chrome/browser/notifications/platform_notification_service_unittest.cc

+++ b/chrome/browser/notifications/platform_notification_service_unittest.cc

@@ -231,9 +231,12 @@ TEST_F(PlatformNotificationServiceTest, DisplayPersistentNotificationMatches) {

notification_data.actions[0].title = base::ASCIIToUTF16("Button 1");

notification_data.actions[1].title = base::ASCIIToUTF16("Button 2");

+ NotificationResources notification_resources;

+ notification_resources.action_icons.resize(notification_data.actions.size());

service()->DisplayPersistentNotification(

profile(), 0u /* persistent notification */, GURL("https://chrome.com/"),

- notification_data, NotificationResources());

+ notification_data, notification_resources);

ASSERT_EQ(1u, ui_manager()->GetNotificationCount());