Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1681013002: DevTools: [Console] wrap long strings in console (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Console] wrap long strings in console The "white-space: pre" was introduced in crrev.com/1304033003 to avoid spaces collapsing. The "white-space: pre-wrap" does not collapse spaces and wraps text if needed. BUG=583644 R=pfeldman, dgozman Committed: https://crrev.com/8fa870ed97a19658f438db9b9f5b3548cb47bf4a Cr-Commit-Position: refs/heads/master@{#374292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/components/objectValue.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
lushnikov
ptal
4 years, 10 months ago (2016-02-09 01:40:12 UTC) #1
dgozman
lgtm
4 years, 10 months ago (2016-02-09 01:43:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681013002/1
4 years, 10 months ago (2016-02-09 02:11:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 04:22:32 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8fa870ed97a19658f438db9b9f5b3548cb47bf4a Cr-Commit-Position: refs/heads/master@{#374292}
4 years, 10 months ago (2016-02-09 04:23:30 UTC) #7
sergeyv
4 years, 10 months ago (2016-02-11 20:38:10 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1689273002/ by sergeyv@chromium.org.

The reason for reverting is: Huge blocks of text in inline values,
scopechainsidebarpane

BUG=586256.

Powered by Google App Engine
This is Rietveld 408576698