Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1681003003: Revert of Pass both 32 and 64 bit snapshot and natives fds to child processes. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
android-webview-reviews_chromium.org, avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass both 32 and 64 bit snapshot and natives fds to child processes. (patchset #3 id:40001 of https://codereview.chromium.org/1665513002/ ) Reason for revert: Added a static initializer: https://build.chromium.org/p/chromium/builders/Linux/builds/71576 # v8_initializer.cc _GLOBAL__sub_I_v8_initializer.cc+0xf # v8_initializer.cc __cxa_atexit@plt [registers a dtor to run at exit] Original issue's description: > Pass both 32 and 64 bit snapshot and natives fds to child processes. > > Child processes are in the best position to determine which files > to use, therefore it is simplest just to provide both 32 and 64 > bit versions from the parent. > > BUG=581380, 455699 > > Committed: https://crrev.com/c560d75783aca05249092dd11503b53f7b631be1 > Cr-Commit-Position: refs/heads/master@{#374371} TBR=jochen@chromium.org,torne@chromium.org,tobiasjs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581380, 455699 Committed: https://crrev.com/09ea387c322ef962ab795f82b75b8c24d4a1da1f Cr-Commit-Position: refs/heads/master@{#374380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -162 lines) Patch
M android_webview/lib/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +18 lines, -14 lines 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/child_process_launcher.cc View 2 chunks +1 line, -28 lines 0 comments Download
M content/public/common/content_descriptors.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gin/v8_initializer.h View 1 chunk +0 lines, -13 lines 0 comments Download
M gin/v8_initializer.cc View 8 chunks +39 lines, -89 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of Pass both 32 and 64 bit snapshot and natives fds to child ...
4 years, 10 months ago (2016-02-09 15:34:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681003003/1
4 years, 10 months ago (2016-02-09 15:35:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 15:36:48 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 15:38:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09ea387c322ef962ab795f82b75b8c24d4a1da1f
Cr-Commit-Position: refs/heads/master@{#374380}

Powered by Google App Engine
This is Rietveld 408576698