Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1680943003: Support pdfium compilation with xcode 10.11 and higher (Closed)

Created:
4 years, 10 months ago by Wei Li
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang, Tom Sepez, Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comment and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -5 lines) Patch
A build/gyp/tools/mac_find_sdk.py View 1 1 chunk +93 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Wei Li
mac_find_sdk in this CL is a copy of chromium's find_sdk.py. PTAL, thanks.
4 years, 10 months ago (2016-02-09 23:11:43 UTC) #2
Wei Li
Looks like Nico is swamped. And more people start running into this problem. Lei or ...
4 years, 10 months ago (2016-02-23 19:02:01 UTC) #5
Nico
looks generally fine (sorry, didn't see this first time round) https://codereview.chromium.org/1680943003/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1680943003/diff/1/build/standalone.gypi#newcode419 ...
4 years, 10 months ago (2016-02-23 19:04:52 UTC) #6
Wei Li
https://codereview.chromium.org/1680943003/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1680943003/diff/1/build/standalone.gypi#newcode419 build/standalone.gypi:419: 'mac_sdk%': '<!(python <(DEPTH)/build/gyp/tools/mac_find_sdk.py <(mac_sdk_min))', On 2016/02/23 19:04:52, Nico wrote: ...
4 years, 10 months ago (2016-02-23 20:00:36 UTC) #7
Nico
On 2016/02/23 20:00:36, Wei Li wrote: > https://codereview.chromium.org/1680943003/diff/1/build/standalone.gypi > File build/standalone.gypi (right): > > https://codereview.chromium.org/1680943003/diff/1/build/standalone.gypi#newcode419 ...
4 years, 10 months ago (2016-02-23 20:34:00 UTC) #8
Wei Li
On 2016/02/23 20:34:00, Nico wrote: > On 2016/02/23 20:00:36, Wei Li wrote: > > https://codereview.chromium.org/1680943003/diff/1/build/standalone.gypi ...
4 years, 10 months ago (2016-02-23 21:27:10 UTC) #10
Lei Zhang
lgtm https://codereview.chromium.org/1680943003/diff/1/build/gyp/tools/mac_find_sdk.py File build/gyp/tools/mac_find_sdk.py (right): https://codereview.chromium.org/1680943003/diff/1/build/gyp/tools/mac_find_sdk.py#newcode2 build/gyp/tools/mac_find_sdk.py:2: # Copyright (c) 2012 The Chromium Authors. All ...
4 years, 10 months ago (2016-02-23 21:29:07 UTC) #11
Wei Li
On 2016/02/23 21:29:07, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/1680943003/diff/1/build/gyp/tools/mac_find_sdk.py > File build/gyp/tools/mac_find_sdk.py (right): ...
4 years, 10 months ago (2016-02-23 21:37:36 UTC) #12
Wei Li
4 years, 10 months ago (2016-02-23 21:44:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
28de044e5d6ab3cb0335ad4e5dd64fdf3376b2eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698