Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1680923003:
Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot (Closed)
DescriptionDisable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot
The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed,
but the flakiness seems not directly related to [1].
This CL temprarily disables the test to reland [1], because [1] fixes race
conditions.
[1] https://codereview.chromium.org/1641853003/
BUG=585026, 581565
Committed: https://crrev.com/c1a9c7fed634d2989108512ade6230d09303bec8
Cr-Commit-Position: refs/heads/master@{#374818}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 18 (8 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680923003/1
Description was changed from ========== Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot BUG=585026, 581565 ========== to ========== Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed, but the flakiness seems not directly related to [1]. This CL temprarily disables the test, because [1] fixes race conditions and thus landing [1] is important. [1] https://codereview.chromium.org/1641853003/ BUG=585026, 581565 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
hiroshige@chromium.org changed reviewers: + sky@chromium.org, ssid@chromium.org
PTAL.
LGTM
On 2016/02/09 20:44:48, sky wrote: > LGTM I think isn't required anymore. crrev.com/1679703002 fixed this.
On 2016/02/10 01:10:43, ssid wrote: > On 2016/02/09 20:44:48, sky wrote: > > LGTM > > I think isn't required anymore. crrev.com/1679703002 fixed this. crrev.com/1679703002 reverted [1], but I'd like to reland [1].
Description was changed from ========== Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed, but the flakiness seems not directly related to [1]. This CL temprarily disables the test, because [1] fixes race conditions and thus landing [1] is important. [1] https://codereview.chromium.org/1641853003/ BUG=585026, 581565 ========== to ========== Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed, but the flakiness seems not directly related to [1]. This CL temprarily disables the test to reland [1], because [1] fixes race conditions. [1] https://codereview.chromium.org/1641853003/ BUG=585026, 581565 ==========
On 2016/02/10 01:31:13, hiroshige wrote: > On 2016/02/10 01:10:43, ssid wrote: > > On 2016/02/09 20:44:48, sky wrote: > > > LGTM > > > > I think isn't required anymore. crrev.com/1679703002 fixed this. > crrev.com/1679703002 reverted [1], but I'd like to reland [1]. Committing this and [1], because there are also MediaValueCached-related lsan reports by clusterfuzz that I couldn't reproduce locally. Let me see whether committing these CLs makes lsan reports better or worse.
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680923003/1
Message was sent while issue was closed.
Description was changed from ========== Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed, but the flakiness seems not directly related to [1]. This CL temprarily disables the test to reland [1], because [1] fixes race conditions. [1] https://codereview.chromium.org/1641853003/ BUG=585026, 581565 ========== to ========== Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed, but the flakiness seems not directly related to [1]. This CL temprarily disables the test to reland [1], because [1] fixes race conditions. [1] https://codereview.chromium.org/1641853003/ BUG=585026, 581565 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed, but the flakiness seems not directly related to [1]. This CL temprarily disables the test to reland [1], because [1] fixes race conditions. [1] https://codereview.chromium.org/1641853003/ BUG=585026, 581565 ========== to ========== Disable flaky SingleProcessTracingBrowserTest.TestMemoryInfra on the asan bot The test is flaky (leaking) on linux_chromium_asan_rel_ng after [1] is landed, but the flakiness seems not directly related to [1]. This CL temprarily disables the test to reland [1], because [1] fixes race conditions. [1] https://codereview.chromium.org/1641853003/ BUG=585026, 581565 Committed: https://crrev.com/c1a9c7fed634d2989108512ade6230d09303bec8 Cr-Commit-Position: refs/heads/master@{#374818} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c1a9c7fed634d2989108512ade6230d09303bec8 Cr-Commit-Position: refs/heads/master@{#374818} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
