Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc

Issue 1680893002: Moving proxy resolution logic out of NetworkDelegate and into ProxyDelegate for DataReductionProxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
index 3fe09d6bf326cd569faecf2ce3f152a61e24035c..16aee3233e347d85378418dba87e702a5ad7eb32 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
@@ -111,32 +111,33 @@ class DataReductionProxyConfigServiceClientTest : public testing::Test {
test_context_ =
DataReductionProxyTestContext::Builder()
.WithParamsDefinitions(TestDataReductionProxyParams::HAS_EVERYTHING)
.WithURLRequestContext(&context_)
.WithMockClientSocketFactory(&mock_socket_factory_)
.WithTestConfigurator()
.WithMockRequestOptions()
.WithTestConfigClient()
.Build();
context_.set_client_socket_factory(&mock_socket_factory_);
+
+ delegate_ = test_context_->io_data()->CreateProxyDelegate();
+ context_.set_proxy_delegate(delegate_.get());
+
context_.Init();
ResetBackoffEntryReleaseTime();
test_context_->test_config_client()->SetNow(base::Time::UnixEpoch());
test_context_->test_config_client()->SetEnabled(true);
enabled_proxies_for_http_ =
test_context_->test_params()->proxies_for_http();
test_context_->test_config_client()->SetConfigServiceURL(
GURL("http://configservice.com"));
- delegate_.reset(
- new DataReductionProxyDelegate(request_options(), config()));
-
// Set up the various test ClientConfigs.
ClientConfig config =
CreateConfig(kSuccessSessionKey, kConfingRefreshDurationSeconds, 0,
ProxyServer_ProxyScheme_HTTPS, "origin.net", 443,
ProxyServer_ProxyScheme_HTTP, "fallback.net", 80);
config.SerializeToString(&config_);
encoded_config_ = EncodeConfig(config);
ClientConfig previous_config =
CreateConfig(kOldSuccessSessionKey, kConfingRefreshDurationSeconds, 0,

Powered by Google App Engine
This is Rietveld 408576698