Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1680873002: [Experimental Framework] Move trial token code to renderer (Closed)

Created:
4 years, 10 months ago by iclelland
Modified:
4 years, 10 months ago
Reviewers:
chasej, jam
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, chasej+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Experimental Framework] Move trial token code to renderer In order to make the code changes easier to reason about, this is now part 1 of a two-part commit. In this commit, the existing code is moved from content/common and content/child into content/renderer (it isn't used anywhere else). In part 2, the keys are moved out of content into the embedder. Part 2: https://codereview.chromium.org/1653263005/ BUG=543220 Committed: https://crrev.com/5c7359f5e920964da0219705bdeacafac75ac078 Cr-Commit-Position: refs/heads/master@{#374763}

Patch Set 1 #

Patch Set 2 : Add boringssl dependency to content/renderer/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -511 lines) Patch
M content/child/blink_platform_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D content/child/origin_trials/trial_token_validator.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/child/origin_trials/trial_token_validator.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D content/common/origin_trials/trial_token.h View 1 chunk +0 lines, -96 lines 0 comments Download
D content/common/origin_trials/trial_token.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D content/common/origin_trials/trial_token_unittest.cc View 1 chunk +0 lines, -192 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 2 chunks +5 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + content/renderer/origin_trials/trial_token.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/origin_trials/trial_token.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/origin_trials/trial_token_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/origin_trials/trial_token_validator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/origin_trials/trial_token_validator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
iclelland
+r chasej, +r jam -- PTAL, thanks!
4 years, 10 months ago (2016-02-08 21:27:51 UTC) #3
jam
On 2016/02/08 21:27:51, iclelland wrote: > +r chasej, +r jam -- PTAL, thanks! lgtm, thanks
4 years, 10 months ago (2016-02-09 04:43:15 UTC) #4
chasej
lgtm
4 years, 10 months ago (2016-02-10 05:27:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680873002/20001
4 years, 10 months ago (2016-02-10 17:45:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/21406)
4 years, 10 months ago (2016-02-10 20:38:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680873002/20001
4 years, 10 months ago (2016-02-10 21:34:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 22:59:43 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:04 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c7359f5e920964da0219705bdeacafac75ac078
Cr-Commit-Position: refs/heads/master@{#374763}

Powered by Google App Engine
This is Rietveld 408576698