Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1680853002: Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
jcgregorio, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (patchset #2 id:20001 of https://codereview.chromium.org/1681643002/ ) Reason for revert: Breaking cmake build Original issue's description: > Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. > SkJSONCanvas and SkJSONRenderer will be deleted once the debug server > has been updated. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002 > > Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e TBR=jcgregorio@google.com,joshualitt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/2df781327a0ab5e66bdc3cf3f9ce9bc6eb00b943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1929 lines) Patch
M src/utils/debugger/SkDrawCommand.h View 31 chunks +5 lines, -86 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 30 chunks +0 lines, -1839 lines 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ethannicholas
Created Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas.
4 years, 10 months ago (2016-02-08 19:36:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680853002/1
4 years, 10 months ago (2016-02-08 19:36:55 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 19:37:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2df781327a0ab5e66bdc3cf3f9ce9bc6eb00b943

Powered by Google App Engine
This is Rietveld 408576698