cc: Remove RasterWorkerPool::Task.

cc/resources/raster_worker_pool_perftest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/raster_worker_pool.h"
 
 #include "base/time/time.h"
 #include "cc/resources/direct_raster_worker_pool.h"
 #include "cc/resources/image_raster_worker_pool.h"
 #include "cc/resources/pixel_buffer_raster_worker_pool.h"
@@ skipping 111 matching lines @@
  public:
   PerfDirectRasterWorkerPoolImpl(ResourceProvider* resource_provider,
                                  ContextProvider* context_provider)
       : DirectRasterWorkerPool(resource_provider, context_provider) {}
 };
 
 class RasterWorkerPoolPerfTest
     : public testing::TestWithParam<RasterWorkerPoolType>,
       public RasterWorkerPoolClient {
  public:
-  class Task : public RasterWorkerPool::Task {
-   public:
-    typedef std::vector<Task> Vector;
-
-    static Task Create() { return Task(new PerfWorkerPoolTaskImpl); }
-
-    void AppendTo(internal::WorkerPoolTask::Vector* dependencies) const {
-      dependencies->push_back(internal_);
-    }
-
-   private:
-    explicit Task(internal::WorkerPoolTask* task)
-        : RasterWorkerPool::Task(task) {}
-  };
-
-  class RasterTask : public RasterWorkerPool::RasterTask {
-   public:
-    typedef std::vector<RasterTask> Vector;
-
-    static RasterTask Create(scoped_ptr<ScopedResource> resource,
-                             const Task::Vector& image_decode_tasks) {
-      internal::WorkerPoolTask::Vector dependencies;
-      for (Task::Vector::const_iterator it = image_decode_tasks.begin();
-           it != image_decode_tasks.end();
-           ++it)
-        it->AppendTo(&dependencies);
-
-      return RasterTask(
-          new PerfRasterWorkerPoolTaskImpl(resource.Pass(), &dependencies));
-    }
-
-   private:
-    explicit RasterTask(internal::RasterWorkerPoolTask* task)
-        : RasterWorkerPool::RasterTask(task) {}
-  };
+  typedef std::vector<scoped_refptr<internal::RasterWorkerPoolTask> >
+      RasterTaskVector;
 
   RasterWorkerPoolPerfTest()
       : context_provider_(TestContextProvider::Create()),
         task_graph_runner_(new PerfTaskGraphRunnerImpl),
         timer_(kWarmupRuns,
                base::TimeDelta::FromMilliseconds(kTimeLimitMillis),
                kTimeCheckInterval) {
     output_surface_ = FakeOutputSurface::Create3d(context_provider_).Pass();
     CHECK(output_surface_->BindToClient(&output_surface_client_));
 
@@ skipping 36 matching lines @@
     base::MessageLoop::current()->Quit();
   }
   virtual void DidFinishRunningTasksRequiredForActivation() OVERRIDE {}
 
   void RunMessageLoopUntilAllTasksHaveCompleted() {
     while (task_graph_runner_->RunTaskForTesting())
       continue;
     base::MessageLoop::current()->Run();
   }
 
-  void CreateImageDecodeTasks(unsigned num_image_decode_tasks,
-                              Task::Vector* image_decode_tasks) {
+  void CreateImageDecodeTasks(
+      unsigned num_image_decode_tasks,
+      internal::WorkerPoolTask::Vector* image_decode_tasks) {
     for (unsigned i = 0; i < num_image_decode_tasks; ++i)
-      image_decode_tasks->push_back(Task::Create());
+      image_decode_tasks->push_back(new PerfWorkerPoolTaskImpl);
   }
 
-  void CreateRasterTasks(unsigned num_raster_tasks,
-                         const Task::Vector& image_decode_tasks,
-                         RasterTask::Vector* raster_tasks) {
+  void CreateRasterTasks(
+      unsigned num_raster_tasks,
+      const internal::WorkerPoolTask::Vector& image_decode_tasks,
+      RasterTaskVector* raster_tasks) {
     const gfx::Size size(1, 1);
 
     for (unsigned i = 0; i < num_raster_tasks; ++i) {
       scoped_ptr<ScopedResource> resource(
           ScopedResource::Create(resource_provider_.get()));
       resource->Allocate(size, ResourceProvider::TextureUsageAny, RGBA_8888);
 
+      internal::WorkerPoolTask::Vector dependencies = image_decode_tasks;
       raster_tasks->push_back(
-          RasterTask::Create(resource.Pass(), image_decode_tasks));
+          new PerfRasterWorkerPoolTaskImpl(resource.Pass(), &dependencies));
     }
   }
 
-  void BuildTaskQueue(RasterWorkerPool::RasterTask::Queue* tasks,
-                      const RasterTask::Vector& raster_tasks) {
-    for (RasterTask::Vector::const_iterator it = raster_tasks.begin();
+  void BuildTaskQueue(RasterTaskQueue* queue,
+                      const RasterTaskVector& raster_tasks) {
+    for (RasterTaskVector::const_iterator it = raster_tasks.begin();
          it != raster_tasks.end();
          ++it)
-      tasks->Append(*it, false);
+      queue->items.push_back(RasterTaskQueue::Item(it->get(), false));
   }
 
   void RunScheduleTasksTest(const std::string& test_name,
                             unsigned num_raster_tasks,
                             unsigned num_image_decode_tasks) {
-    Task::Vector image_decode_tasks;
-    RasterTask::Vector raster_tasks;
+    internal::WorkerPoolTask::Vector image_decode_tasks;
+    RasterTaskVector raster_tasks;
     CreateImageDecodeTasks(num_image_decode_tasks, &image_decode_tasks);
     CreateRasterTasks(num_raster_tasks, image_decode_tasks, &raster_tasks);
 
     // Avoid unnecessary heap allocations by reusing the same queue.
-    RasterWorkerPool::RasterTask::Queue queue;
+    RasterTaskQueue queue;
 
     timer_.Reset();
     do {
       queue.Reset();
       BuildTaskQueue(&queue, raster_tasks);
       raster_worker_pool_->ScheduleTasks(&queue);
       raster_worker_pool_->CheckForCompletedTasks();
       timer_.NextLap();
     } while (!timer_.HasTimeLimitExpired());
 
-    RasterWorkerPool::RasterTask::Queue empty;
+    RasterTaskQueue empty;
     raster_worker_pool_->ScheduleTasks(&empty);
     RunMessageLoopUntilAllTasksHaveCompleted();
 
     perf_test::PrintResult("schedule_tasks",
                            "",
                            test_name,
                            timer_.LapsPerSecond(),
                            "runs/s",
                            true);
   }
 
   void RunScheduleAlternateTasksTest(const std::string& test_name,
                                      unsigned num_raster_tasks,
                                      unsigned num_image_decode_tasks) {
     const size_t kNumVersions = 2;
-    Task::Vector image_decode_tasks[kNumVersions];
-    RasterTask::Vector raster_tasks[kNumVersions];
+    internal::WorkerPoolTask::Vector image_decode_tasks[kNumVersions];
+    RasterTaskVector raster_tasks[kNumVersions];
     for (size_t i = 0; i < kNumVersions; ++i) {
       CreateImageDecodeTasks(num_image_decode_tasks, &image_decode_tasks[i]);
       CreateRasterTasks(
           num_raster_tasks, image_decode_tasks[i], &raster_tasks[i]);
     }
 
     // Avoid unnecessary heap allocations by reusing the same queue.
-    RasterWorkerPool::RasterTask::Queue queue;
+    RasterTaskQueue queue;
 
     size_t count = 0;
     timer_.Reset();
     do {
       queue.Reset();
       BuildTaskQueue(&queue, raster_tasks[count % kNumVersions]);
       raster_worker_pool_->ScheduleTasks(&queue);
       raster_worker_pool_->CheckForCompletedTasks();
       ++count;
       timer_.NextLap();
     } while (!timer_.HasTimeLimitExpired());
 
-    RasterWorkerPool::RasterTask::Queue empty;
+    RasterTaskQueue empty;
     raster_worker_pool_->ScheduleTasks(&empty);
     RunMessageLoopUntilAllTasksHaveCompleted();
 
     perf_test::PrintResult("schedule_alternate_tasks",
                            "",
                            test_name,
                            timer_.LapsPerSecond(),
                            "runs/s",
                            true);
   }
 
   void RunScheduleAndExecuteTasksTest(const std::string& test_name,
                                       unsigned num_raster_tasks,
                                       unsigned num_image_decode_tasks) {
-    Task::Vector image_decode_tasks;
-    RasterTask::Vector raster_tasks;
+    internal::WorkerPoolTask::Vector image_decode_tasks;
+    RasterTaskVector raster_tasks;
     CreateImageDecodeTasks(num_image_decode_tasks, &image_decode_tasks);
     CreateRasterTasks(num_raster_tasks, image_decode_tasks, &raster_tasks);
 
     // Avoid unnecessary heap allocations by reusing the same queue.
-    RasterWorkerPool::RasterTask::Queue queue;
+    RasterTaskQueue queue;
 
     timer_.Reset();
     do {
       queue.Reset();
       BuildTaskQueue(&queue, raster_tasks);
       raster_worker_pool_->ScheduleTasks(&queue);
       RunMessageLoopUntilAllTasksHaveCompleted();
       timer_.NextLap();
     } while (!timer_.HasTimeLimitExpired());
 
-    RasterWorkerPool::RasterTask::Queue empty;
+    RasterTaskQueue empty;
     raster_worker_pool_->ScheduleTasks(&empty);
     RunMessageLoopUntilAllTasksHaveCompleted();
 
     perf_test::PrintResult("schedule_and_execute_tasks",
                            "",
                            test_name,
                            timer_.LapsPerSecond(),
                            "runs/s",
                            true);
   }
@@ skipping 36 matching lines @@
 }
 
 INSTANTIATE_TEST_CASE_P(RasterWorkerPoolPerfTests,
                         RasterWorkerPoolPerfTest,
                         ::testing::Values(RASTER_WORKER_POOL_TYPE_PIXEL_BUFFER,
                                           RASTER_WORKER_POOL_TYPE_IMAGE,
                                           RASTER_WORKER_POOL_TYPE_DIRECT));
 
 }  // namespace
 }  // namespace cc