Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: src/crankshaft/hydrogen-instructions.cc

Issue 1680783002: [intrinsics] Kill the %_IsMinusZero intrinsic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/hydrogen-range-analysis.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen-instructions.cc
diff --git a/src/crankshaft/hydrogen-instructions.cc b/src/crankshaft/hydrogen-instructions.cc
index ff46d6ad7367c934b285a2dbc6f44740bb47a5a7..8af0c62e6d475cd5e8cb1061c09671d3de35998f 100644
--- a/src/crankshaft/hydrogen-instructions.cc
+++ b/src/crankshaft/hydrogen-instructions.cc
@@ -783,7 +783,6 @@ bool HInstruction::CanDeoptimize() {
case HValue::kCompareGeneric:
case HValue::kCompareHoleAndBranch:
case HValue::kCompareMap:
- case HValue::kCompareMinusZeroAndBranch:
case HValue::kCompareNumericAndBranch:
case HValue::kCompareObjectEqAndBranch:
case HValue::kConstant:
@@ -3326,31 +3325,6 @@ bool HCompareNumericAndBranch::KnownSuccessorBlock(HBasicBlock** block) {
}
-bool HCompareMinusZeroAndBranch::KnownSuccessorBlock(HBasicBlock** block) {
- if (FLAG_fold_constants && value()->IsConstant()) {
- HConstant* constant = HConstant::cast(value());
- if (constant->HasDoubleValue()) {
- *block = IsMinusZero(constant->DoubleValue())
- ? FirstSuccessor() : SecondSuccessor();
- return true;
- }
- }
- if (value()->representation().IsSmiOrInteger32()) {
- // A Smi or Integer32 cannot contain minus zero.
- *block = SecondSuccessor();
- return true;
- }
- *block = NULL;
- return false;
-}
-
-
-void HCompareMinusZeroAndBranch::InferRepresentation(
- HInferRepresentationPhase* h_infer) {
- ChangeRepresentation(value()->representation());
-}
-
-
std::ostream& HGoto::PrintDataTo(std::ostream& os) const { // NOLINT
return os << *SuccessorAt(0);
}
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/hydrogen-range-analysis.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698