Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Issue 1680743006: [Media Router] Show user email in header if cloud sink is present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More adjustments to get dynamic height change working and updated domain handling. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
index 2df8bbd342301586cf634caa12ace39893ab23d0..a192e030185c38f0dee179392358aba7bc98e599 100644
--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
@@ -52,6 +52,7 @@
</template>
<media-router-header id="container-header"
class$="[[currentView_]]" view="[[currentView_]]"
+ email-text="[[computeEmailText_(showEmail, userEmail)]]"
apacible 2016/02/11 17:09:14 userEmail isn't defined in media_router_container.
amp 2016/02/11 21:21:24 I'll try to do this, but I will need a little more
heading-text="[[computeHeaderText_(currentView_, headerText)]]"
arrow-drop-icon-disabled="[[computeIsLaunching_(currentLaunchingSinkId_)]]"
tooltip="[[computeHeaderTooltip_(currentView_, headerTextTooltip)]]"
@@ -123,7 +124,7 @@
<template is="dom-if"
if="[[!computeSinkDomainHidden_(item)]]">
<span class="sink-domain">
- [[item.domain]]
+ [[computeSinkDomainText_(item.domain)]]
</span>
</template>
</div>

Powered by Google App Engine
This is Rietveld 408576698