chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js - Issue 1680743006: [Media Router] Show user email in header if cloud sink is present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Issue 1680743006: [Media Router] Show user email in header if cloud sink is present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix breaks in native code and address comments. Everything works with no bugs detected in this pat… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css » ('j') | chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

diff --git a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

index 4a2bd33a44766bb793c8cd635ef61e7483b212e5..80fc6dd96d8c73ceae330da26274b4b9e1ea3fa1 100644

--- a/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

+++ b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

@@ -382,6 +382,7 @@ Polymer({

listeners: {

+ 'header-height-changed': 'updateElementPositioning_',

'header-or-arrow-click': 'toggleCastModeHidden_',

'mouseleave': 'onMouseLeave_',

'mouseenter': 'onMouseEnter_',

@@ -731,9 +732,7 @@ Polymer({

* @private

computeSinkDomainHidden_: function(sink) {

- // TODO(amp): Check the domain of Chrome profile identity and only show the

- // sink domain if it doesn't match the profile domain. crbug.com/570797

- return this.isEmptyOrWhitespace_(sink.domain);

+ return !this.showDomain || this.isEmptyOrWhitespace_(sink.domain);

imcheng 2016/02/17 00:51:08 showDomain should be defined above in the properti

amp 2016/02/17 02:11:37 Done.

/**