chrome/browser/resources/media_router/media_router.js - Issue 1680743006: [Media Router] Show user email in header if cloud sink is present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/media_router/media_router.js

Issue 1680743006: [Media Router] Show user email in header if cloud sink is present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Overhauled implementation to use observers and fire events as well as push down logic into native m… Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js ('K') | « chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js ('k') | chrome/browser/resources/media_router/media_router_ui_interface.js » ('j') | chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/media_router/media_router.js

diff --git a/chrome/browser/resources/media_router/media_router.js b/chrome/browser/resources/media_router/media_router.js

index 026ff364a1b676aa96b570ecd67f0d3611849f35..1b3deceabfe269e0a6875a1ca1a213c381a8f483 100644

--- a/chrome/browser/resources/media_router/media_router.js

+++ b/chrome/browser/resources/media_router/media_router.js

@@ -28,7 +28,11 @@ cr.define('media_router', function() {

container = /** @type {!MediaRouterContainerElement} */

($('media-router-container'));

- media_router.ui.setContainer(container);

+ var header = /** @type {!MediaRouterHeaderElement} */

+ ($('media-router-header'));

+ media_router.ui.setElements(container, header);

apacible 2016/02/13 08:13:02 Inline the header here. We set |container| as a va

amp 2016/02/16 22:19:12 Done.

container.addEventListener('acknowledge-first-run-flow',

onAcknowledgeFirstRunFlow);