Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168073002: Remove the --ui-max-frames-pending flag. (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, nkostylev+watch_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, stevenjb+watch_chromium.org, cc-bugs_chromium.org, davemoore+watch_chromium.org, brianderson_google
Visibility:
Public.

Description

Remove the --ui-max-frames-pending flag. ChromeOS always sets this value to 1. Other Aura platforms don't use the cc scheduler yet so they don't care about this value. Once they do, they'll want to use 1 as well. So set it to 1 always. R=piman@chromium.org, piman BUG=344094 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252091

Patch Set 1 #

Patch Set 2 : uimaxframespending: #

Patch Set 3 : uimaxframespending: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 1 1 chunk +1 line, -10 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
danakj
6 years, 10 months ago (2014-02-15 00:53:11 UTC) #1
piman
lgtm
6 years, 10 months ago (2014-02-15 00:54:22 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-15 00:55:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168073002/1
6 years, 10 months ago (2014-02-15 01:00:23 UTC) #4
danakj
Removed the ifdef OS_CHROMEOS
6 years, 10 months ago (2014-02-15 01:03:54 UTC) #5
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-15 01:05:42 UTC) #6
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 10 months ago (2014-02-15 01:05:48 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-15 01:06:06 UTC) #8
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
6 years, 10 months ago (2014-02-15 01:24:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168073002/110001
6 years, 10 months ago (2014-02-15 01:25:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-15 03:46:30 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264953
6 years, 10 months ago (2014-02-15 03:46:32 UTC) #12
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-18 22:06:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168073002/110001
6 years, 10 months ago (2014-02-18 22:09:17 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 00:37:24 UTC) #15
commit-bot: I haz the power
Failed to apply patch for ui/compositor/compositor_switches.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-19 00:37:25 UTC) #16
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-19 00:43:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168073002/530001
6 years, 10 months ago (2014-02-19 00:44:30 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 01:59:46 UTC) #19
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=266048
6 years, 10 months ago (2014-02-19 01:59:47 UTC) #20
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-19 16:12:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168073002/530001
6 years, 10 months ago (2014-02-19 16:16:01 UTC) #22
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 10 months ago (2014-02-19 17:08:43 UTC) #23
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-19 17:09:13 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/168073002/530001
6 years, 10 months ago (2014-02-19 17:12:22 UTC) #25
danakj
6 years, 10 months ago (2014-02-19 21:11:53 UTC) #26
Message was sent while issue was closed. 
Committed patchset #3 manually as r252091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698