Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1680703002: Remove import of AnalysisException from wrong library. (Closed)

Created:
4 years, 10 months ago by Bill Hesse
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove import of AnalysisException from wrong library. The class comes from generated/java_engine.dart, not generated/engine.dart BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/b2010369515427e4018162f2440ce2db7220e5c2

Patch Set 1 #

Patch Set 2 : Also remove import of NodeLocator from wrong library. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 10 months ago (2016-02-08 14:53:49 UTC) #2
Paul Berry
lgtm
4 years, 10 months ago (2016-02-08 15:08:19 UTC) #3
Bill Hesse
4 years, 10 months ago (2016-02-08 16:27:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b2010369515427e4018162f2440ce2db7220e5c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698