Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1680683002: Make error message deterministic (Closed)

Created:
4 years, 10 months ago by vsm
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, Jennifer Messerly
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make error message deterministic We are tracking/regressing errors and warnings on the DDC bots, and keep getting spurious diffs like this: https://codereview.chromium.org/1649583002/diff/1/test/codegen/expect/collection/wrappers.txt This change should keep things sorted. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8efb58ae2006452f8b180e470ad9bace7f162e77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 10 months ago (2016-02-08 14:23:13 UTC) #3
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-08 14:46:48 UTC) #4
vsm
4 years, 10 months ago (2016-02-08 15:28:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8efb58ae2006452f8b180e470ad9bace7f162e77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698