Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: net/quic/quic_stream_sequencer_test.cc

Issue 1680643002: Refactor gmock_mutant.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_sequencer_test.cc
diff --git a/net/quic/quic_stream_sequencer_test.cc b/net/quic/quic_stream_sequencer_test.cc
index 3fb6bdacc26e063e92a7f93ab051b6c7986dd141..a19d6961bdb438dbb0845dec7beef858591b4bb7 100644
--- a/net/quic/quic_stream_sequencer_test.cc
+++ b/net/quic/quic_stream_sequencer_test.cc
@@ -182,7 +182,8 @@ INSTANTIATE_TEST_CASE_P(QuicStreamSequencerTests,
TEST_P(QuicStreamSequencerTest, RejectOldFrame) {
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 3)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 3)));
OnFrame(0, "abc");
@@ -211,7 +212,8 @@ TEST_P(QuicStreamSequencerTest, RejectBufferedFrame) {
TEST_P(QuicStreamSequencerTest, FullFrameConsumed) {
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 3)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 3)));
OnFrame(0, "abc");
EXPECT_EQ(0u, NumBufferedBytes());
@@ -227,14 +229,16 @@ TEST_P(QuicStreamSequencerTest, BlockedThenFullFrameConsumed) {
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 3)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 3)));
sequencer_->SetUnblocked();
EXPECT_EQ(0u, NumBufferedBytes());
EXPECT_EQ(3u, sequencer_->NumBytesConsumed());
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 3)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 3)));
EXPECT_FALSE(sequencer_->IsClosed());
OnFinFrame(3, "def");
EXPECT_TRUE(sequencer_->IsClosed());
@@ -249,7 +253,8 @@ TEST_P(QuicStreamSequencerTest, BlockedThenFullFrameAndFinConsumed) {
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 3)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 3)));
EXPECT_FALSE(sequencer_->IsClosed());
sequencer_->SetUnblocked();
EXPECT_TRUE(sequencer_->IsClosed());
@@ -275,7 +280,8 @@ TEST_P(QuicStreamSequencerTest, EmptyFinFrame) {
TEST_P(QuicStreamSequencerTest, PartialFrameConsumed) {
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 2)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 2)));
OnFrame(0, "abc");
EXPECT_EQ(1u, NumBufferedBytes());
@@ -312,7 +318,8 @@ TEST_P(QuicStreamSequencerTest, OutOfOrderFrameProcessed) {
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 9)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 9)));
// Now process all of them at once.
OnFrame(0, "abc");
@@ -327,7 +334,8 @@ TEST_P(QuicStreamSequencerTest, BasicHalfCloseOrdered) {
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 3)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 3)));
OnFinFrame(0, "abc");
EXPECT_EQ(3u, QuicStreamSequencerPeer::GetCloseOffset(sequencer_.get()));
@@ -340,7 +348,8 @@ TEST_P(QuicStreamSequencerTest, BasicHalfCloseUnorderedWithFlush) {
OnFrame(3, "def");
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 6)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 6)));
EXPECT_FALSE(sequencer_->IsClosed());
OnFrame(0, "abc");
EXPECT_TRUE(sequencer_->IsClosed());
@@ -352,7 +361,8 @@ TEST_P(QuicStreamSequencerTest, BasicHalfUnordered) {
EXPECT_CALL(stream_, OnDataAvailable())
.WillOnce(testing::Invoke(
- CreateFunctor(this, &QuicStreamSequencerTest::ConsumeData, 3)));
+ CreateFunctor(&QuicStreamSequencerTest::ConsumeData,
+ base::Unretained(this), 3)));
EXPECT_FALSE(sequencer_->IsClosed());
OnFrame(0, "abc");
EXPECT_TRUE(sequencer_->IsClosed());
« no previous file with comments | « net/quic/quic_session_test.cc ('k') | remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698