Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1680643002: Refactor gmock_mutant.h (Closed)

Created:
4 years, 10 months ago by tzik
Modified:
4 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, extensions-reviews_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor gmock_mutant.h This CL contains: * Expose resulting type of Bind as MakeUnboundRunType. * Refactor testing::CreateFunctor using base::Bind. * Remove generate_gmock_mutant.py. * Change argument ordering of testing::CreateFunctor to align to base::Bind. * Remove LATE_OBJECT_BINDING support, which no one use. BUG=554299 Committed: https://crrev.com/651fa1249144a42032c20e4e82f87e995f5d7dff Cr-Commit-Position: refs/heads/master@{#374689}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -5572 lines) Patch
M base/bind.h View 1 2 3 1 chunk +19 lines, -5 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_apitest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M net/quic/quic_chromium_client_stream_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_session_test.cc View 5 chunks +24 lines, -11 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 9 chunks +20 lines, -10 lines 0 comments Download
M remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
D testing/generate_gmock_mutant.py View 1 chunk +0 lines, -451 lines 0 comments Download
M testing/gmock_mutant.h View 1 2 3 4 chunks +29 lines, -5083 lines 0 comments Download

Messages

Total messages: 41 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680643002/1
4 years, 10 months ago (2016-02-08 06:09:22 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/164989)
4 years, 10 months ago (2016-02-08 06:57:20 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680643002/20001
4 years, 10 months ago (2016-02-08 07:40:29 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/165006)
4 years, 10 months ago (2016-02-08 08:31:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680643002/40001
4 years, 10 months ago (2016-02-08 08:43:08 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680643002/60001
4 years, 10 months ago (2016-02-08 09:18:48 UTC) #14
tzik
PTAL
4 years, 10 months ago (2016-02-08 10:29:15 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 11:48:57 UTC) #20
tzik
Oops, sorry. I forgot to guide which directory you guys might be interested in. Could ...
4 years, 10 months ago (2016-02-08 12:40:16 UTC) #21
mmenke
On 2016/02/08 12:40:16, tzik wrote: > Oops, sorry. I forgot to guide which directory you ...
4 years, 10 months ago (2016-02-08 12:42:52 UTC) #22
Nico
lgtm, nice!
4 years, 10 months ago (2016-02-08 15:37:12 UTC) #23
joedow
remoting/ lgtm.
4 years, 10 months ago (2016-02-08 16:22:22 UTC) #25
Dirk Pranke
I am totally unqualified to review this, so I defer to thakis@. lgtm based on ...
4 years, 10 months ago (2016-02-08 21:20:03 UTC) #26
tzik
dmazzoni: ping. Could you review tts_extension_apitest.cc?
4 years, 10 months ago (2016-02-10 03:53:40 UTC) #27
Nico
tts_extension_apitest.cc lgtm as chrome/OWNER (it's just a refactoring change, so I feel comfortable stamping this)
4 years, 10 months ago (2016-02-10 13:45:24 UTC) #28
tzik
On 2016/02/10 13:45:24, Nico wrote: > tts_extension_apitest.cc lgtm as chrome/OWNER (it's just a refactoring change, ...
4 years, 10 months ago (2016-02-10 16:36:42 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680643002/60001
4 years, 10 months ago (2016-02-10 16:37:17 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/20061) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-10 16:43:36 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1680643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1680643002/60001
4 years, 10 months ago (2016-02-10 17:06:35 UTC) #35
dmazzoni
lgtm
4 years, 10 months ago (2016-02-10 17:43:06 UTC) #36
tzik
On 2016/02/10 17:43:06, dmazzoni wrote: > lgtm Thanks!
4 years, 10 months ago (2016-02-10 17:43:45 UTC) #37
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-10 18:30:35 UTC) #39
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 18:32:18 UTC) #41
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/651fa1249144a42032c20e4e82f87e995f5d7dff
Cr-Commit-Position: refs/heads/master@{#374689}

Powered by Google App Engine
This is Rietveld 408576698